-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type issue: removeSubscription function has been removed from NativeEventEmitter, but its type is not updated #39111
Comments
|
The version has been updated in the original issue report. |
Thanks for the report @Yupeng-li |
@cortinico Thank you for the quick reply. I've created a pull request #39115 to fix it. |
…ter (#39115) Summary: Removed deprecated function removeSubscription from the type of NativeEventEmitter, so that it lines up with its implementation. This is a fix for #39111 . ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Fix a type issue of NativeEventEmitter Pull Request resolved: #39115 Test Plan: Not applicable Reviewed By: NickGerleman Differential Revision: D48573676 Pulled By: lunaleaps fbshipit-source-id: e70c951e230e0d236e0bf0a1ba02b450bdc98ac5
Description
removeSubscription(subscription: EmitterSubscription): void;
has been removed from NativeEventEmitter in this commit. However, the type file is not updated.React Native Version
0.71.12
Output of
npx react-native info
Steps to reproduce
The details are in the "Description" section above.
Snack, screenshot, or link to a repository
https://snack.expo.dev/@yupeng_li/nativeeventemitter-removesubscription
The text was updated successfully, but these errors were encountered: