Build fails for Xcode 15 Beta 1 (and Beta 7) #37748

below · 2023-06-07T06:50:09Z

Description

When building with Xcode 15 Beta 1, building fails with a C++ issue in boost:

› Compiling react-native Pods/RCT-Folly » json.cpp

❌  (ios/Pods/boost/boost/container_hash/hash.hpp:131:33)

  129 | #else
  130 |         template <typename T>
> 131 |         struct hash_base : std::unary_function<T, std::size_t> {};
      |                                 ^ no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
  132 | #endif
  133 | 
  134 |         struct enable_hash_value { typedef std::size_t type; };

Apparently, boost 1.8x does not have this issue and builds correctly. However, react-jsi currently does not work with boost 1.8x due to breaking changes.

React Native Version

0.71.8

Output of `npx react-native info`

>> npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 13.4
    CPU: (10) arm64 Apple M1 Pro
    Memory: 124.09 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 19.4.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.5 - /opt/homebrew/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.12.1 - /opt/homebrew/lib/ruby/gems/3.1.0/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.1 AI-221.6008.13.2211.9619390
    Xcode: 15.0/15A5160n - /usr/bin/xcodebuild
  Languages:
    Java: javac 19 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: 0.71.8 => 0.71.8 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

Prerequisite: On a machine running macOS, ensure that Xcode 15 is installed
Download or clone this Sample
cd react-Xcode15Bug
npm install && (cd ios && pod install)

Then either:

yarn ios

Or

xed ios and build with Xcode

Snack, code example, screenshot, or link to a repository

https://github.com/below/react-Xcode15Bug

The text was updated successfully, but these errors were encountered:

below · 2023-06-07T07:34:34Z

facing the same issue.

Thanks you for confirming reproducibility

Armanoide · 2023-06-07T09:51:52Z

what happening

unary_function and binary_function are no longer provided in C++17 and newer Standard modes. They can be re-enabled with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.

release note xcode 15

What must be done

all library must update their code to use std::function & std::bind instead of unary_function

Workaround

Select Pods > Build Settings > In section Apple Clang - Preprocessing > under Macro section
add in release & debug _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION

tested on Xcode 15 with react-native 0.71.7

below · 2023-06-07T10:03:34Z

Thank you @Armanoide for pointing this out. In production, this will usually be have to be done via a post-install script in the Podfile, as the Pods are often re-generated.

The other workaround is to patch hash.hpp locally

Armanoide · 2023-06-07T11:26:45Z

Thank you @Armanoide for pointing this out. In production, this will usually be have to be done via a post-install script in the Podfile, as the Pods are often re-generated.

The other workaround is to patch hash.hpp locally

you're right @below to notice that Pods is re-generated.
To complete answer this should be added in podfile

  post_install do |installer|
      installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
          config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
        end
      end
  end

cipolleschi · 2023-06-07T14:47:25Z

@Armanoide thanks so much for the work around. We will bake this into our Cocoapods scripts... or if you have time and you want to open a PR, that's very welcome! :D

Armanoide · 2023-06-07T23:56:22Z

@Armanoide thanks so much for the work around. We will bake this into our Cocoapods scripts... or if you have time and you want to open a PR, that's very welcome! :D

i didn't have time today unfortunately but some one did 37758.
It will be soon in the next version of RN 📦

tido64 · 2023-06-08T09:04:33Z

Do we have a separate task for upgrading Boost to a version that doesn't use std::unary_function? I would imagine that we won't be able to even turn this on in a future version.

below · 2023-06-08T09:43:58Z

@tido64 As of my quick research, boost 1.8.x no longer uses std::unary_function. And yes, this would be the preferable solution to setting options in the Podfile

tido64 · 2023-06-08T10:06:10Z

@tido64 As of my quick research, boost 1.8.x no longer uses std::unary_function. And yes, this would be the preferable solution to setting options in the Podfile

Had a quick look myself. std::unary_function was removed in 2019, but Boost didn't bump ContainerHash until last December 😢

GraxMonzo · 2023-06-12T06:33:49Z

Hi, this problem still exists in version 0.71.10, are there plans to add this in 0.71.x?

cipolleschi · 2023-06-12T17:44:58Z

@GraxMonzo: Yes, as soon as we release 0.71.11 (either this week or the next) the problem will be fixed there as well.

Summary: Fixes #37748 This PR adds a patch which fixes a build issue in Xcode 15. ## Changelog: [IOS] [ADDED] - Add support for building with Xcode 15 Pull Request resolved: #37758 Reviewed By: cortinico Differential Revision: D46524009 Pulled By: cipolleschi fbshipit-source-id: 9f6c12e12a15c154467282a7b4a00e80e5cc0af2

Summary: Fixes facebook#37748 This PR adds a patch which fixes a build issue in Xcode 15. ## Changelog: [IOS] [ADDED] - Add support for building with Xcode 15 Pull Request resolved: facebook#37758 Reviewed By: cortinico Differential Revision: D46524009 Pulled By: cipolleschi fbshipit-source-id: 9f6c12e12a15c154467282a7b4a00e80e5cc0af2 (cherry picked from commit 8ed2cfd)

ben-haim · 2023-07-06T10:14:34Z

You're correct that there is no template named unary_function in the std namespace. The error message suggests using __unary_function instead

See: facebook/react-native#37748.

* fix(iOS): bump `LNViewHierarchyDumper` to version 1.3. Current version is broken with Xcode 15.0/iOS 17. * fix(iOS): add workaround for building with Xcode 15. See: facebook/react-native#37748. * fix(iOS): bump `LNViewHierarchyDumper` submodule. Fixes unrecognized selector sent to errors.

jitanshu · 2023-08-03T06:50:53Z

Replacing unary_function with __unary_function worked for me

cipolleschi · 2023-08-18T10:14:47Z

@marcshilling can you share the crashlog?

cipolleschi · 2023-08-21T09:41:00Z

We are aware of issues related to Xcode 15, beta, especially when it comes to older iOS.
Can you try if that happens with more recent betas?

marcshilling · 2023-08-21T14:09:40Z

@cipolleschi this is Xcode 15 Beta 6 which is the latest, trying to run on iOS 17 Beta 6!

cipolleschi · 2023-08-21T17:47:07Z

uhm... the title of the issue says Beta 1, that's why I was asking.
Anyway, in our tests, iOS 17 and Xcode beta 6 are working properly. We are having issues with Xcode 15 beta 6 and older iOSes, though... but we haven't found a solution yet, unfortunately, as, even for us, the stack trace is pretty empty...

sthales · 2023-08-25T15:01:06Z

@cipolleschi I don't know how to print a better crash log than this. Again it only happens when running/debugging through > Xcode. Execution just stops as soon as the app launches with this SIGABRT:

Same issue here.
iOS 17 beta 7.
xCode 15 beta 7.

marcshilling · 2023-08-25T20:36:22Z

Yeah still happening for me in beta 7 as well (the startup SIGABRT). Here's crash report. I sent it to Apple as well in case this is some beta issue 🤷

Code Type:           X86-64 (Native)
Role:                Foreground
Parent Process:      launchd_sim [26423]
Coalition:           com.apple.CoreSimulator.SimDevice.249DDD8B-78A4-4847-98B3-29645FFF9567 [76346]
Responsible Process: SimulatorTrampoline [24850]

Date/Time:           2023-08-25 16:33:58.9305 -0400
Launch Time:         2023-08-25 16:33:57.5265 -0400
OS Version:          macOS 13.5.1 (22G90)
Release Type:        User
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: OBJC 1 

Triggered by Thread:  0

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x114d49a52 __abort_with_payload + 10
1   libsystem_kernel.dylib        	       0x114d6784e abort_with_payload_wrapper_internal + 82
2   libsystem_kernel.dylib        	       0x114d677fc abort_with_reason + 19
3   libobjc.A.dylib               	    0x7ff800057593 _objc_fatalv(unsigned long long, unsigned long long, char const*, __va_list_tag*) + 121
4   libobjc.A.dylib               	    0x7ff80005751a _objc_fatal(char const*, ...) + 114
5   libobjc.A.dylib               	    0x7ff80004166d load_images + 1383
6   dyld_sim                      	       0x11389509b dyld4::RuntimeState::notifyObjCInit(dyld4::Loader const*) + 359
7   dyld_sim                      	       0x11389a73c dyld4::Loader::runInitializersBottomUp(dyld4::RuntimeState&, dyld3::Array<dyld4::Loader const*>&) const + 182
8   dyld_sim                      	       0x11389d49a dyld4::Loader::runInitializersBottomUpPlusUpwardLinks(dyld4::RuntimeState&) const::$_1::operator()() const + 92
9   dyld_sim                      	       0x11389a7dd dyld4::Loader::runInitializersBottomUpPlusUpwardLinks(dyld4::RuntimeState&) const + 93
10  dyld_sim                      	       0x1138b03df dyld4::APIs::runAllInitializersForMain() + 263
11  dyld_sim                      	       0x11388c10a dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 2535
12  dyld_sim                      	       0x11388b356 _dyld_sim_prepare + 854
13  dyld                          	       0x117f55424 dyld4::prepareSim(dyld4::RuntimeState&, char const*) + 1490
14  dyld                          	       0x117f53abc dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 249
15  dyld                          	       0x117f533bd start + 1805

Edit: Confirming issue is still present with Beta 8 :(

kelset · 2023-08-29T09:00:29Z

reopening for now since it seems that Beta 7 is having issues

cipolleschi · 2023-08-29T10:07:26Z

@marcshilling thanks for doing that. Keep us updated on how it goes. I plan to do the same today, hopefully, the more error they receive the more pressured they may feel

@sthales I'll try again, but on my test it was working on iOS 17.0

Meanwhile, I made some investigation.

Combination Broken vs Working

Xcode \ iOS	iOS 14.5	iOS 15.0	iOS 16.0	iOS 17.0
Xcode 15 beta 1	✅	✅	✅	✅
Xcode 15 beta 2	✅	✅	✅	✅
Xcode 15 beta 3*	N/A	N/A	N/A	N/A
Xcode 15 beta 4	❌	✅	✅	✅
Xcode 15 beta 5	❌	✅	✅	✅
Xcode 15 beta 6	❌	✅	✅	✅
Xcode 15 beta 7	❌	✅	✅	✅

Xcode 15 Beta 3 can't be downloaded, the archive is corrupted somehow.
So, it is broke either in beta 3 or beta 4.

What's the issue

What got broken is in how C++ allocates memory.

In the latest versions, I can trigger the crash on iOS 14.5 with a simple:

shared_ptr<string> strPtr = make_shared<string>("");

The first stack trace reported the issue with Folly, specifically the AccessSpreaderStaticInit. Fun fact, we don't need the CacheLocality in React Native.

I made a test by removing that file from the Folly's Podspec: React Native still builds, but it also still crash. In this situation, we don't have any code coming from the framework.

I tried to reproduce the issue in a native iOS project without React Native: it does not crash.

There is something within React Native that tampers with how the memory is allocated in iOS 14.5, but I couldn't pin what it is specifically.

Daniel-Griffiths · 2023-09-08T09:53:44Z

what happening

unary_function and binary_function are no longer provided in C++17 and newer Standard modes. They can be re-enabled with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.

release note xcode 15

What must be done

all library must update their code to use std::function & std::bind instead of unary_function

Workaround

Select Pods > Build Settings > In section Apple Clang - Preprocessing > under Macro section

add in release & debug _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION

tested on Xcode 15 with react-native 0.71.7

Can confirm this worked for me, thanks!

NikolaSimsic · 2023-09-12T11:35:21Z

Just to confirm that solution provided by Armanoide works smooth!

cipolleschi · 2023-09-12T12:22:19Z

Manually modifying your project works, but our infra is already doing it in the react_native_post_install hook.
It calls this function which is implemented here. Make sure that you are calling the hook in your Podfile.

humanzai · 2023-09-13T11:51:31Z

Xcode Cloud builds with Xcode 15 fails now with the same issue on react native < 5.4.2 which doesn't have this fix and no way to insert this workaround.

what happening

unary_function and binary_function are no longer provided in C++17 and newer Standard modes. They can be re-enabled with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.

release note xcode 15

What must be done

all library must update their code to use std::function & std::bind instead of unary_function

Workaround

Select Pods > Build Settings > In section Apple Clang - Preprocessing > under Macro section

add in release & debug _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION

tested on Xcode 15 with react-native 0.71.7

cipolleschi · 2023-09-13T12:38:29Z

@humanzai you mean that Xcode cloud can't run cocoapods? If that the case, you'll have to check into your versioning system the pods and the xcworkspace for Xcode cloud to pick up the right file.
All these configurations are applied by our Cocoapod infra.

humanzai · 2023-09-13T14:18:53Z

@cipolleschi Thanks for the clarification!
For future reference to anyone:
If you have your own pods in the project, this workaround should be applied on the "projectname.xcodeproj" configurations. That way when adding the flag on preprocessors macros through the UI, the projectname.xcodeproj will be updated - you can commit the file to your git repository which is connected to Xcode cloud and it will fix the issue.

For third party Pods,
This solution did the trick for me:

Thank you @Armanoide for pointing this out. In production, this will usually be have to be done via a post-install script in the Podfile, as the Pods are often re-generated.
The other workaround is to patch hash.hpp locally

you're right @below to notice that Pods is re-generated. To complete answer this should be added in podfile
  post_install do |installer|
      installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
          config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
        end
      end
  end

Thanks everyone

MihaiEros · 2023-09-19T08:07:20Z

what happening

unary_function and binary_function are no longer provided in C++17 and newer Standard modes. They can be re-enabled with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.

release note xcode 15

What must be done

all library must update their code to use std::function & std::bind instead of unary_function

Workaround

Select Pods > Build Settings > In section Apple Clang - Preprocessing > under Macro section

add in release & debug _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION

tested on Xcode 15 with react-native 0.71.7

Thank you very much! 🍻

kelset · 2023-09-19T09:11:16Z

btw folks, we are going to release new patches for all the versions in the support window with fixes for Xcode 15. @cipolleschi has already added comments in all the patches discussion with the links to the commits to pick.

…o unblock iOS build Summary: Linear: https://linear.app/comm/issue/ENG-4984/xcode-version-15-update GitHub: facebook/react-native#37748 --- Depends on D9227 Test Plan: iOS builds succeeds after `yarn cleaninstall` without issue. Reviewers: ashoat, ginsu, tomek, bartek Reviewed By: ashoat Differential Revision: https://phab.comm.dev/D9228

After upgrading to Xcode 15 make run-ios would fail with ``` ❌ /Users/siddarthkumar/code/status-im/PR/status-mobile/ios/Pods/boost/boost/container_hash/hash.hpp:131:33: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'? struct hash_base : std::unary_function<T, std::size_t> {}; ``` This commit fixes the issue and makes existing codebase compatible with newer Xcode. reference issue in react-native repo : facebook/react-native#37748

mrlexz · 2023-09-20T10:43:30Z

thanks Armanoide, this worked for me!!

Shubham0850 · 2023-09-20T14:22:53Z

Hi, I encountered the same problem today after updating my iPhone to iOS 17 and Xcode to 15.0. I managed to fix the iOS build failure by replacing 'unary_function' with '__unary_function'. However, when I tried running the app on my iOS 17 (iPhone 13), I got a 'Paused app on iPhone' message and the app didn't start.

React native Version: react-native@0.71.7

Here are the SS

marcshilling · 2023-09-20T14:43:29Z

@Shubham0850 hey, refer to this issue: mrousavy/react-native-vision-camera#1802 (comment)

this one is unrelated

cipolleschi · 2023-09-20T15:20:05Z

All the fixes for Xcode 15 has landed on main and they have been cherry picked in the right branch.
Brace with us for a few days, while the Release Crew prepares new Releases for each of the supported versions (0.70, 0.71 and 0.72).

Thank you all for your patience.

below added the Needs: Triage 🔍 label Jun 7, 2023

This comment was marked as duplicate.

Sign in to view

cortinico added Platform: iOS iOS applications. Tool: Xcode and removed Needs: Triage 🔍 labels Jun 7, 2023

AlexanderEggers mentioned this issue Jun 7, 2023

Add support for building with Xcode 15 #37758

Closed

cortinico added the Resolution: PR Submitted A pull request with a fix has been provided. label Jun 7, 2023

cortinico mentioned this issue Jun 8, 2023

Bug Report: React Native Compatibility Issue with Xcode 15 Beta 1 Version #37765

Closed

facebook-github-bot closed this as completed in 10d5588 Jun 8, 2023

GraxMonzo mentioned this issue Jun 11, 2023

IOS Build fails for Xcode 15 expo/expo#22832

Closed

leotm mentioned this issue Jun 21, 2023

Upgrade React Native to 0.71.6 MetaMask/metamask-mobile#6220

Merged

3 tasks

rolandkakonyi mentioned this issue Jul 27, 2023

Add workaround for building with Xcode 15 bitmovin/bitmovin-player-react-native#172

Merged

asafkorem added a commit to wix/Detox that referenced this issue Aug 2, 2023

fix(iOS): add workaround for building with Xcode 15.

f0f7df2

See: facebook/react-native#37748.

asafkorem mentioned this issue Aug 2, 2023

fix(iOS): ensure compatibility with Xcode 15. wix/Detox#4152

Merged

kelset reopened this Aug 29, 2023

kelset changed the title ~~Build fails for Xcode 15 Beta 1~~ Build fails for Xcode 15 Beta 1 (and Beta 7) Aug 29, 2023

cipolleschi mentioned this issue Aug 30, 2023

App crashes on iOS 14 when built and run with Xcode 15 beta6, but works fine on iOS 17 #39069

Closed

leotm mentioned this issue Aug 31, 2023

First time build issue MetaMask/metamask-mobile#6158

Closed

cipolleschi closed this as completed Sep 12, 2023

siddarthkay mentioned this issue Sep 20, 2023

add support for Xcode 15 status-im/status-mobile#17343

Merged

facebook locked as resolved and limited conversation to collaborators Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build fails for Xcode 15 Beta 1 (and Beta 7) #37748

Build fails for Xcode 15 Beta 1 (and Beta 7) #37748

below commented Jun 7, 2023

This comment was marked as duplicate.

below commented Jun 7, 2023

Armanoide commented Jun 7, 2023 •

edited

Loading

below commented Jun 7, 2023

Armanoide commented Jun 7, 2023

cipolleschi commented Jun 7, 2023

Armanoide commented Jun 7, 2023

tido64 commented Jun 8, 2023

below commented Jun 8, 2023

tido64 commented Jun 8, 2023

GraxMonzo commented Jun 12, 2023

cipolleschi commented Jun 12, 2023

ben-haim commented Jul 6, 2023

jitanshu commented Aug 3, 2023

cipolleschi commented Aug 18, 2023

cipolleschi commented Aug 21, 2023

marcshilling commented Aug 21, 2023

cipolleschi commented Aug 21, 2023

sthales commented Aug 25, 2023 •

edited

Loading

marcshilling commented Aug 25, 2023 •

edited

Loading

kelset commented Aug 29, 2023

cipolleschi commented Aug 29, 2023

Daniel-Griffiths commented Sep 8, 2023

NikolaSimsic commented Sep 12, 2023

cipolleschi commented Sep 12, 2023

humanzai commented Sep 13, 2023

cipolleschi commented Sep 13, 2023

humanzai commented Sep 13, 2023

MihaiEros commented Sep 19, 2023

kelset commented Sep 19, 2023

mrlexz commented Sep 20, 2023

Shubham0850 commented Sep 20, 2023 •

edited

Loading

marcshilling commented Sep 20, 2023 •

edited

Loading

cipolleschi commented Sep 20, 2023

Build fails for Xcode 15 Beta 1 (and Beta 7) #37748

Build fails for Xcode 15 Beta 1 (and Beta 7) #37748

Comments

below commented Jun 7, 2023

Description

React Native Version

Output of npx react-native info

Steps to reproduce

Snack, code example, screenshot, or link to a repository

This comment was marked as duplicate.

below commented Jun 7, 2023

Armanoide commented Jun 7, 2023 • edited Loading

below commented Jun 7, 2023

Armanoide commented Jun 7, 2023

cipolleschi commented Jun 7, 2023

Armanoide commented Jun 7, 2023

tido64 commented Jun 8, 2023

below commented Jun 8, 2023

tido64 commented Jun 8, 2023

GraxMonzo commented Jun 12, 2023

cipolleschi commented Jun 12, 2023

ben-haim commented Jul 6, 2023

jitanshu commented Aug 3, 2023

cipolleschi commented Aug 18, 2023

cipolleschi commented Aug 21, 2023

marcshilling commented Aug 21, 2023

cipolleschi commented Aug 21, 2023

sthales commented Aug 25, 2023 • edited Loading

marcshilling commented Aug 25, 2023 • edited Loading

kelset commented Aug 29, 2023

cipolleschi commented Aug 29, 2023

Combination Broken vs Working

What's the issue

Daniel-Griffiths commented Sep 8, 2023

NikolaSimsic commented Sep 12, 2023

cipolleschi commented Sep 12, 2023

humanzai commented Sep 13, 2023

cipolleschi commented Sep 13, 2023

humanzai commented Sep 13, 2023

MihaiEros commented Sep 19, 2023

kelset commented Sep 19, 2023

mrlexz commented Sep 20, 2023

Shubham0850 commented Sep 20, 2023 • edited Loading

marcshilling commented Sep 20, 2023 • edited Loading

cipolleschi commented Sep 20, 2023

Output of `npx react-native info`

Armanoide commented Jun 7, 2023 •

edited

Loading

sthales commented Aug 25, 2023 •

edited

Loading

marcshilling commented Aug 25, 2023 •

edited

Loading

Shubham0850 commented Sep 20, 2023 •

edited

Loading

marcshilling commented Sep 20, 2023 •

edited

Loading