Flavors & App Bundle missing index.android.bundle with proguard enabled

[lorenzoangelini]

Issue

We use the flavors into our apps to use different version. We have dev, test and prod. When we have upgraded to 0.63 (same with 0.64), to classpath("com.android.tools.build:gradle:3.5.3") and distributionUrl=https://services.gradle.org/distributions/gradle-6.2-all.zip and proguard enabled, we cannot use the appbundle.
when we run ./gradlew bundleDevRelease -> we cannot find into the app-dev-release.aab the index.android.bundle. This cause a crash when open the app.
If we run this command : ./gradlew bundleRelease -> it build all variants
app-dev-release.aab -> missing
app-test-release.aab -> index.android.bundle present
app-prod-release.aab -> index.android.bundle present

Description

Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: https://reactnative.dev/docs/upgrading.html

React Native version:

System:
OS: macOS 10.15.7
CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
Memory: 944.16 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 14.15.4 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.14.10 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
Android SDK:
API Levels: 23, 27, 28, 29
Build Tools: 26.0.2, 27.0.3, 28.0.3, 29.0.2, 29.0.3
System Images: android-19 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-27 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.8743.12.41.6953283
Xcode: 12.0/12A7209 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_201 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.0 => 0.64.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Steps To Reproduce

1.Create a new project: npx react-native init AppName --template react-native-template-typescript
2. Add to gradle.build :
productFlavors {
prod {
}
dev {
applicationId 'com.appname.dev'
resValue "string", "build_config_package", "com.appname"
}
test {
applicationId 'com.appname.test'
resValue "string", "build_config_package", "com.appname"
}
}
3. Enable Proguard
4. run into android folder : ./gradlew clean && ./gradlew bundleDevRelease

Expected Results

Obtain an .aab file into android/build/outputs/bundle/devRelease. when i open the .aab i expect to find the folder base and into the base the folder assets that contain the index.android.bundle.

[gedeagas]

@lorenzoangelini This issue has now been resolved in 0.64.
#30177

[lorenzoangelini]

@gedeagas i reproduce this issue when proguard is active

[gedeagas]

@lorenzoangelini Interesting, do you mind providing a git repo of the problem?

@renopp This is probably related to your case ( multiflavors, prod aab dosen't have index.android.bundle, etc ). Let's try to fix this if there is a problem here.

[lorenzoangelini]

@gedeagas with a new project i reproduce this issue when i using flavors.

[davwheat]

Can reproduce on RN 0.64.0. Worked fine before the upgrade on 0.63.x. 🤔

I'd share the git repo, but this app is private for a client.

I don't use productFlavors, only buildTypes.

Debug and prod APKs work fine. Haven't tested a debug AAB.

// build.gradle
buildTypes {
    release {
        signingConfig signingConfigs.release
        minifyEnabled enableProguardInReleaseBuilds
        proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        minifyEnabled true
        shrinkResources true
    }
    releaseUnsigned {
        initWith release
        signingConfig null
        // needed to prevent react native dependency code failing
        // to build
        matchingFallbacks =  ['release']
    }
}

// ------------------------------------------------

// proguard-rules.pro
-keep public class com.horcrux.svg.** {*;}

react-native info output

info Fetching system and libraries information...
System:
    OS: Windows 10 10.0.19042
    CPU: (6) x64 Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz
    Memory: 3.70 GB / 15.94 GB
  Binaries:
    Node: 15.1.0 - ~\AppData\Local\Temp\yarn--1616780838243-0.2835069363144411\node.CMD
    Yarn: 1.22.5 - ~\AppData\Local\Temp\yarn--1616780838243-0.2835069363144411\yarn.CMD
    npm: 7.6.3 - c:\users\david\appdata\roaming\npm\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK:
      API Levels: 23, 24, 25, 26, 28, 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.2, 30.0.3
      System Images: android-26 | Android Wear Intel x86 Atom, android-28 | China version of Wear OS Intel x86 Atom, android-28 | Wear OS Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
    Windows SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Visual Studio: 15.9.28307.1321 (Visual Studio Community 2017)
  Languages:
    Java: 11.0.7 - c:\program files\adoptopenjdk\jdk-11.0.7.10-hotspot\bin\javac.EXE
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: ^0.64.0 => 0.64.0
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

[gedeagas]

@davwheat so it's working on RN 0.63 but not 0.64? hmm.. that is strange.
I will be looking at this on Monday. Thanks for the report.

[davwheat]

It was working before I upgraded on 20th March -- I suppose it could have come in from another change I've made, but I doubt any JS changes would cause it, and I haven't tinkered with my build process at all (except the upgrade process).

If you want me to test anything or give you more info, let me know :)

[lorenzoangelini]

@davwheat me too, i don't have any problem with 0.62, the app bundle was build correctly.

[gedeagas]

@davwheat do you also have proguard turned on like @lorenzoangelini ?

[davwheat]

@gedeagas Yes, I use proguard, including a custom rule which I posted above.

[danaelisanicolas]

Any updates on this? We're also having issues on bundling android releases with proguard enabled

[renopp]

@lorenzoangelini @davwheat @danaelisanicolas
I just created a PR to fix the issue, kindly check