Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button does not announce "disabled" #30934

Closed
amarlette opened this issue Feb 10, 2021 · 1 comment
Closed

Button does not announce "disabled" #30934

amarlette opened this issue Feb 10, 2021 · 1 comment
Labels
Accessibility Component: Button Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@amarlette
Copy link

amarlette commented Feb 10, 2021 •
edited
Loading

Description

When using a screen reader disabled buttons do not announce that they are disabled.

This issue is covered in-depth by parent issue #30840, please check there for more details.

React Native version:

v0.63
@amarlette amarlette mentioned this issue Feb 10, 2021
Closed
19 tasks
@huzaifaaak huzaifaaak mentioned this issue Feb 16, 2021
Closed
@amarlette amarlette added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. and removed Needs: Triage 🔍 labels Mar 5, 2021
facebook-github-bot pushed a commit that referenced this issue Mar 11, 2021
@facebook-github-bot
Added talkback support for button accessibility: disabled prop (#31001)
5889cbe 
Summary:
Issue # #30934 .When using a screen reader disabled buttons do not announce that they are disabled.

## Changelog

[Android] [Changed] - Passing accessibility state in button so it can announce disabled in talkback

Pull Request resolved: #31001

Test Plan:
I have added Button in Button Example with accessibiltyState prop that will announce button is disabled when testing with talkback.

## Ios test
I am unable to run ios project on my machine. RNTesterPods.xcworkspace gives workspace integrity error :/

Reviewed By: kacieb

Differential Revision: D26492483

Pulled By: lunaleaps

fbshipit-source-id: c4bbe8ca896b0d303976591c300ccac67a96ac73
@amarlette
Copy link
Author

Thank you @huzaifaaak for helping improve React Native's accessibility! Closing this issue since the PR #31001 resolves it.

@facebook facebook locked as resolved and limited conversation to collaborators Mar 15, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility Component: Button Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amarlette @react-native-bot