-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.63-rc.0] Android release builds fail on new init projects #28700
Labels
Comments
20 tasks
I'm getting an almost identical issue: react-native-community/upgrade-support#60 |
Definitely a regression after recent change. Has something to do with the |
Closed
Just submitted a PR to fix this issue. |
grabbou
added a commit
that referenced
this issue
Apr 29, 2020
Summary: Running `./gradlew assembleRelease` fails as the path to the CLI contains a new line at the end. We don't run this command in `debug` mode, hence it passed the testing. My bad. Fixed, checked in both `debug` with `bundleInDebug: true` and `release`. Fixes #28700 ## Changelog [INTERNAL] [ANDROID] - Fix `React.gradle` to build Android apps in production Pull Request resolved: #28776 Test Plan: Running `./gradlew assembleRelease` works Reviewed By: hramos Differential Revision: D21287789 Pulled By: TheSavior fbshipit-source-id: dc3ec8eef7a919b072b562d2bd455e2f704bc083
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Description
Building release version of the new 0.63 RC fails at the bundling JS assets step
React Native version:
Run
react-native info
in your terminal and copy the results here.Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
npx react-native init RN063 --version 0.63.0-rc.0
yarn react-native run-android --variant=release
npx react-native init RN062
yarn react-native run-android --variant=release
Works and builds fine
Expected Results
Building a release version of the new RC0.63 should be successful.
Snack, code example, screenshot, or link to a repository:
Simple reproduction shown above.
The text was updated successfully, but these errors were encountered: