Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Regression after 0.59: FlatList in inverted mode on Android doesn't invert pull-to-refresh gesture. #26181

Closed
avinidiktov opened this issue Aug 25, 2019 · 1 comment
Closed

[Android] Regression after 0.59: FlatList in inverted mode on Android doesn't invert pull-to-refresh gesture. #26181

avinidiktov opened this issue Aug 25, 2019 · 1 comment
Labels
Bug Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@avinidiktov
Copy link

Description:

When inverted prop is set to true for FlatList on Android pulling from bottom to top does nothing. But pulling from top to bottom causing refresh indicator to show up on top and calling onRefresh.

iOS works as expected.

The problem doesn't exist for React Native 0.59.8.

React Native version:

System:
OS: macOS 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 1.80 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.16.0 - /usr/local/opt/node@10/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/opt/node@10/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 27, 28
Build Tools: 27.0.3, 28.0.3
System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.5 => 0.60.5
npmGlobalPackages:
react-native-cli: 2.0.1

Steps To Reproduce

  1. Use FlatList on Android;
  2. Set inverted prop;
  3. Pull the list up. The indicator will not be displayed;
  4. Pull the list down. The indicator will be displayed at the top of the screen.

Describe what you expected to happen:

The indicator must be displayed at the bottom of the screen.

Snack, code example, screenshot, or link to a repository:

The same code works differently.

Wrong behavior demo (react-native: 0.60.5):
wrong
https://github.com/avinidiktov/flatlist-bug

Expected behavior demo (react-native: 0.59.8):
expected
https://snack.expo.io/@doktorwin/flatlist-bug
@react-native-bot react-native-bot added Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Platform: Android Android applications. labels Aug 25, 2019
@AurangzaibRamzan
Copy link

Same issue

@migbot migbot mentioned this issue Sep 27, 2019
Closed
@vshab vshab mentioned this issue Sep 30, 2019
Closed
grabbou pushed a commit that referenced this issue Oct 2, 2019
@migbot @grabbou
Include transform in OUTER_PROPS (#26611)
b944381 
Summary:
Without `transform` in `OUTER_PROPS`, the refresh control component would not include `transform: {scaleY: -1}` in its style and so pulling down, rather than up, on a scroll view would trigger a refresh.

Fixes #26181

## Changelog
[Android] [Fixed] - Fixed issue with refresh control not working properly on an inverted ScrollView
Pull Request resolved: #26611

Test Plan: Updated unit test in splitLayoutProps-test.js.

Differential Revision: D17661079

Pulled By: cpojer

fbshipit-source-id: 747da27b11c3ca59b7f639f393ae5ac137f5490a
@facebook facebook locked as resolved and limited conversation to collaborators Oct 4, 2021
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Component: FlatList Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include transform in OUTER_PROPS migbot/react-native
3 participants
@avinidiktov @AurangzaibRamzan @react-native-bot