Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Template needs updating #24917

Closed
orta opened this issue May 16, 2019 · 3 comments
Closed

PR Template needs updating #24917

orta opened this issue May 16, 2019 · 3 comments
Labels
p: Microsoft Partner: Microsoft Resolution: Locked This issue was locked by the bot. Type: Docs Issues concerning the docs are tracked elsewhere: https://github.com/facebook/react-native-website

Comments

@orta
Copy link
Contributor

orta commented May 16, 2019 

<!-- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. -->

This now redirects back to contributing.md which doesn't include a reference on how to write a changelog entry.
@orta orta added the Type: Docs Issues concerning the docs are tracked elsewhere: https://github.com/facebook/react-native-website label May 16, 2019
@hramos
Copy link
Contributor

hramos commented May 16, 2019

Thanks for the heads up. If anyone wants to send a PR, we now have the relevant content in the wiki. e.g.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. Category can be "iOS", "Android", "JavaScript", or "General", while Type can be "Added", "Changed", "Removed", and so on. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[Category] [Type] - Message

@ericlewis
Copy link
Contributor

@orta do you also forget the values each time? 😆

@ericlewis ericlewis mentioned this issue May 16, 2019
Closed
@orta
Copy link
Contributor Author

orta commented May 16, 2019

Hah, yep, I let the bot tell me 💯

@hramos hramos added the p: Microsoft Partner: Microsoft label Aug 9, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this issue Mar 10, 2020
@ericlewis @M-i-k-e-l
Update PR template changelog link (facebook#24919)
4a2fba0 
Summary:
fix facebook#24917.

## Changelog

[Internal] [Changed] - Update PR template changelog link
Pull Request resolved: facebook#24919

Differential Revision: D15385773

Pulled By: hramos

fbshipit-source-id: 81a220efc3999942bd41ddf7cbd3107a755cfebd
@facebook facebook locked as resolved and limited conversation to collaborators May 16, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: Microsoft Partner: Microsoft Resolution: Locked This issue was locked by the bot. Type: Docs Issues concerning the docs are tracked elsewhere: https://github.com/facebook/react-native-website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PR template changelog link ericlewis/react-native
4 participants
@orta @hramos @ericlewis @react-native-bot