Crash on reportSoftException when lineNumber is missing

[arudnev]

🐛 Bug Report

Android app crashes when ExceptionsManagerModule.reportSoftException is called with a stack trace that has frames without lineNumber.

The following fatal exception is logged.

2019-04-09 16:14:29.742 7083-7781/? E/AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
    Process: co.armortext.messenger, PID: 7083
    com.facebook.react.bridge.NoSuchKeyException: lineNumber
        at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:124)
        at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:128)
        at com.facebook.react.bridge.ReadableNativeMap.getInt(ReadableNativeMap.java:182)
        at com.facebook.react.util.JSStackTrace.format(JSStackTrace.java:28)
        at com.facebook.react.modules.core.ExceptionsManagerModule.reportSoftException(ExceptionsManagerModule.java:46)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158)
        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
        at android.os.Looper.loop(Looper.java:164)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:232)
        at java.lang.Thread.run(Thread.java:764)

When app is running in debug mode something like this can be shown in red box:

To Reproduce

Log exception via console.error with stack that has frames without line numbers.

Expected Behavior

App should not crash and exception stack trace should be formatted without line numbers similar to how it's shown in red box.

Code Example

I don't have a good code sample but it's clear that problem is in the following code, where certain fields are assumed to be always present:

react-native/ReactAndroid/src/main/java/com/facebook/react/util/JSStackTrace.java

Line 28 in 97eb53d

.append(frame.getInt("lineNumber"));

Environment

info
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (8) x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Memory: 1.31 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 11.13.0 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
npm: 6.7.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 16, 17, 18, 19, 21, 22, 23, 24, 25, 26, 27, 28
Build Tools: 26.0.1, 26.0.2, 27.0.0, 27.0.3, 28.0.0, 28.0.0, 28.0.2, 28.0.3, 29.0.0
System Images: android-21 | Intel x86 Atom, android-21 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.3 AI-182.5107.16.33.5314842
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.59.4 => 0.59.4

[Salakar]

👋 hey @arudnev - thanks for the report, I've just sent up a PR (#24399) for this.

Would appreciate your review if possible - if the lineNumber does not exist I've set it to -1 instead (which is a common thing to do as far as I remember from when I did Stack Traces stuff a couple weeks back)

[tjann]

I am getting the following error

04-10 22:15:19.664  7325  7353 E AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
04-10 22:15:19.664  7325  7353 E AndroidRuntime: Process: com.myappname, PID: 7325
04-10 22:15:19.664  7325  7353 E AndroidRuntime: com.facebook.react.bridge.NoSuchKeyException: lineNumber
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:124)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.ReadableNativeMap.getValue(ReadableNativeMap.java:128)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.ReadableNativeMap.getInt(ReadableNativeMap.java:182)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.util.JSStackTrace.format(JSStackTrace.java:28)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.modules.core.ExceptionsManagerModule.reportSoftException(ExceptionsManagerModule.java:46)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at android.os.Handler.handleCallback(Handler.java:873)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:99)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:193)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:232)
04-10 22:15:19.664  7325  7353 E AndroidRuntime:        at java.lang.Thread.run(Thread.java:764)

This appears to be similar so let me know if providing more information will be helpful.

[karthikpala]

I see that the code is same from 0.52 version of react native. Can anyone please let me know why this issue is coming up in the past week??

[arudnev]

I would expect that in most of older versions the line numbers were generated correctly, but due to some recent issues like facebook/metro#380 there might be some mess with source maps that uncovered need for more defensive code here.

[yogeshchoudhary147]

Same crash for us since 5th April. We are on react-native 0.55.4. Don't know why it started and how to stop it.

[helloagain-dev]

We are on react-native 0.56.0 and noticing this issue since a few days now. We will try to cherry pick that commit: Salakar@ee38bb1 to react-native 0.56.0 and build react native from source.

If anyone has some experience with this, any input would be helpful.

[tjann]

I also tried to build from source and am still trying to recover from that action... I'm inexperienced in react native and mobile in general and there's no documentation to help.

Since installing from source, the strings “path/to/build/directory” consistently fail to get replaced, and firebase is not working.

There's no documentation on undoing install from source either.

Any expert advice will be great!