After upgrading to react-native 0.59 iOS build fails

[dan-lee]

🐛 Bug Report

After updating to react-native 0.59 and trying to build the app for iOS I get the following error:

Build input file cannot be found: '/app/node_modules/react-native/ReactCommon/yoga/yoga/YGFloatOptional.cpp'

What's strange to me is, that I can't find this file here either in the current master: react-native/tree/master/ReactCommon/yoga/yoga (only YGFloatOptional.h)

To Reproduce

We upgraded a mid sized project from 0.57.7 → 0.59.

Expected Behavior

Build should run through just fine like it did before.

Environment

  React Native Environment Info:
    System:
      OS: macOS 10.14.3
      CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
      Memory: 2.95 GB / 32.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 10.15.1 - /var/folders/1r/ymkpxdlj21lb638kzp4jxvwm0000gn/T/yarn--1552463658468-0.20119758467048565/node
      Yarn: 1.13.0 - /var/folders/1r/ymkpxdlj21lb638kzp4jxvwm0000gn/T/yarn--1552463658468-0.20119758467048565/yarn
      npm: 6.4.1 - /usr/local/Cellar/node@10/10.15.1/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        API Levels: 23, 24, 25, 27, 28
        Build Tools: 23.0.1, 23.0.3, 24.0.1, 25.0.0, 27.0.3, 28.0.3
        System Images: android-24 | ARM 64 v8a, android-24 | ARM EABI v7a, android-24 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
    IDEs:
      Android Studio: 3.3 AI-182.5107.16.33.5264788
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.0 => 0.59.0

[jsamr]

I have just reproduced this issue with XCode: 10.1 and RN 0.59.0.

EDIT 1: I could reproduce with XCode UI build tool ; but it's working fine with react-native run-ios (make sure to have the latest 2.x cli).
EDIT 2: I managed to make it work with XCode 10.1 by enabling legacy build. Related to #19573

[darekg11]

Hmm, I have just upgraded from 0.58.4 to 0.59, cleaned build directories in XCode and I was able to run both debug and archive the app. I am using XCode 10.1.
My upgrade strategy:

1. Bump dependencies according to most recent stable version.
2. Walk through each compare in https://github.com/react-native-community/rn-diff-purge and apply it manually.

Wondering if everything might work for me because I had working 0.58.4 and just applied new stuff on top of it?

EDIT: I have also ran npm ci in order to remove my node_modules (just to make sure) and I was still able to build the app from XCode 🤔

EDIT2: And I don't have YGFloatOptional.cpp:

[philipaarseth]

I'm getting the same issue upgrading from 0.57.8 -> 0.59.1.
Looking at a fresh 0.59.1 init there is no YGFloatOptional.cpp file.

[jpudysz]

Add these lines to your Podfile:

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

and run

pod install

[jsamr]

@jpudysz Yeah that worked after migrating to cocoapod and opening the XCode project with the .xcworkspace file.
I had to react-native unlink and react-native link bridged libraries so that they use the Podfile instead.

Should legacy (no-cocoapod) linking be deprecated ?

[lukefanning]

@jpudysz Worked for me too. Surely this can't be the proper solution though right? This seriously bloats the project. Pods/boost-for-react-native is 160.8MB.

Edit: Ok seriously odd, I removed those 3 pods, ran Clean in Xcode and tried to build. This time I didn't get an error while compiling Yoga.

[RaphArbuz]

Thanks @jpudysz . Following your solution, I then get the following error:
'folly/Portability.h' file not found in JSBundleType.h

Does anyone know what's going on?

Many thanks.

[philipaarseth]

After trying what feels like pretty much everything, RN standard upgrade, git upgrade tool, applying diff patch I ended up recreating a completely new project and doing the extremely tedious work of rebuilding the code base. They say it'll be better from 0.59 on.. hopefully they're right about that

[Ericky14]

I just upgraded from 0.59.0 to 0.59.1 and it worked for me
resolved the Yoga issue

[RaphArbuz]

I upgraded too but with no luck so far.

[matthias-pichler]

I had the exact same issue. The good old rm -rf node_modules && npm i and cleaning the build folders did it for me

[tungduonghgg123]

After using npm audit fix, my 'react-native' are upgraded automatically to version 0.59 and I can't not build my project.
Solution: Downgrade version to lower one.
npm install react-native@<version>
example : npm install react-native@0.57.8

[thiagoferolla]

I've tried updating from 0.58.4 manually (following rn-diff-purge changes) but I'm also facing this problem with RN 0.59.0 or 0.59.1