Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PushNotificationIOS.removeEventListener method signature requires unused handler Function #23868

Closed
schumannd opened this issue Mar 12, 2019 · 4 comments
Closed

PushNotificationIOS.removeEventListener method signature requires unused handler Function #23868

schumannd opened this issue Mar 12, 2019 · 4 comments
Labels
API: PushNotificationIOS Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Enhancement A new feature or enhancement of an existing feature.

Comments

@schumannd
Copy link

react-native/Libraries/PushNotificationIOS/PushNotificationIOS.js

Line 236 in 726d001

handler: Function,

This throws unhelpful flow errors. If this is an error, I can provide a PR removing this line.
@react-native-bot
Copy link
Collaborator

Thanks for submitting your issue. Can you take another look at your description and make sure the issue template has been filled in its entirety?

👉 Click here if you want to take another look at the Bug Report issue template.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: Needs More Information labels Mar 12, 2019
@ericlewis
Copy link
Contributor

@schumannd it seems unused, you could try removing it.

@cpojer cpojer mentioned this issue Mar 19, 2019
Closed
@grabbou grabbou added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Type: Enhancement A new feature or enhancement of an existing feature. and removed Resolution: Needs More Information labels Mar 19, 2019
@grabbou
Copy link
Contributor

grabbou commented Mar 19, 2019

I think we should actually fix the code to handle multiple listeners. Right now, if you call addEventListener two times, the latter one will silently overwrite the former one.

I believe this is kind of behaviour you wouldn't expect.

If the API is designed to only handle single handler, it should be setEventListener.

This was referenced Mar 19, 2019
Closed
Closed
@cpojer cpojer mentioned this issue Mar 25, 2019
Open
@cpojer
Copy link
Contributor

cpojer commented Mar 25, 2019

This issue has been moved to react-native-push-notification/ios#10.

@cpojer cpojer closed this as completed Mar 25, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 25, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API: PushNotificationIOS Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cpojer @ericlewis @grabbou @schumannd @react-native-bot