Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectionList with sticky headers scrolls jumpy when virtualization is enabled #21468

Closed
3 tasks done
a-golovanov opened this issue Oct 4, 2018 · 6 comments
Closed
3 tasks done
Labels
Bug Component: SectionList Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@a-golovanov
Copy link

a-golovanov commented Oct 4, 2018

Environment

React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Memory: 201.34 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
Yarn: 1.10.1 - ~/.nvm/versions/node/v8.12.0/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
Android SDK:
Build Tools: 22.0.1, 23.0.1, 23.0.3, 25.0.0, 25.0.1, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
API Levels: 22, 23, 25, 26, 27, 28
IDEs:
Android Studio: 3.2 AI-181.5540.7.32.5014246
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
@storybook/react-native: ^4.0.0-alpha.21 => 4.0.0-alpha.23
react: 16.5.0 => 16.5.0
react-native: ^0.57.1 => 0.57.1

Description

After upgrading from RN 54 to 57 scrolling of section list becomes jumpy when virtualization kicks in, see video. We traced this issue to change list e0c7363, reverting the change locally fixes the issue.

Reproducible Demo

Create a SectionList with sticky headers, populate it with a long items list with multiple sections, scroll down until virtualization kicks in, watch items jump all other the place (there should be a few sections present in the virtualized space.

@a-golovanov
Copy link
Author

a-golovanov commented Oct 4, 2018

Relates to #21198

@danilobuerger
Copy link
Contributor

Duplicate of #20956

facebook-github-bot pushed a commit that referenced this issue Feb 4, 2019
Summary:
Fixes #20956, #21361, #21198, #21468
Keeps the intended outcome of #18105
Pull Request resolved: #22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
erwamartin pushed a commit to erwamartin/react-native that referenced this issue Feb 5, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
@hramos hramos removed the Bug Report label Feb 6, 2019
erwamartin pushed a commit to erwamartin/react-native that referenced this issue Feb 7, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
erwamartin pushed a commit to erwamartin/react-native that referenced this issue Feb 21, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
sjchmiela pushed a commit to expo/react-native that referenced this issue Mar 22, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
bruchim pushed a commit to wix-playground/react-native that referenced this issue Mar 24, 2019
Summary:
Fixes facebook#20956, facebook#21361, facebook#21198, facebook#21468
Keeps the intended outcome of facebook#18105
Pull Request resolved: facebook#22025

Differential Revision: D13941915

Pulled By: cpojer

fbshipit-source-id: 59a0a834ea2d0dd4678e80a82ddaf95cecf87d38
@stale
Copy link

stale bot commented Sep 18, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 18, 2019
@timothystewart6
Copy link

Hey, I was running into this too and found a workaround. I ended up setting a few additional properties, these in particular:

     initialNumToRender={50}
     maxToRenderPerBatch={50}
     windowSize={41}

I opted out of RN's defaults (because I am dealing with a large list) and this seems to fix the headers from jumping all over when scrolling. Your mileage may vary.

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 19, 2019
@stale
Copy link

stale bot commented Dec 18, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 18, 2019
@stale
Copy link

stale bot commented Dec 25, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Dec 25, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: SectionList Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

5 participants