-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListHeaderComponent should not be considered the top of a list view #17743
Labels
Ran Commands
One of our bots successfully processed a command.
Stale
There has been a lack of activity on this issue and it may be closed soon.
Comments
Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version? I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer. |
react-native-bot
added
Ran Commands
One of our bots successfully processed a command.
Stale
There has been a lack of activity on this issue and it may be closed soon.
labels
Feb 24, 2018
This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
mkdirenv@gmail.com
Domain salmanwaheed.info has exceeded the max emails per hour (175/150 (116%)) allowed. Message will be reattempted later
…------- This is a copy of the message, including all the headers. ------
Received: from o8.sgmail.github.com ([167.89.101.199]:31290)
by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.89_1)
(envelope-from <bounces+848413-a7b0-hello=salmanwaheed.info@sgmail.github.com>)
id 1epQVf-003JSw-2u
for hello@salmanwaheed.info; Fri, 23 Feb 2018 20:28:27 -0700
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=JTTF2MnfjBV0HzUDiUmW91LZpiM=; b=EKsYamUYkkyxXzJT
NqMw4PenFzNTBx8EqI41EQ+CISCZKlni9jOmauyiVfsx5uLmoy1mJDFbkls3RuZk
V8hBU8UFjBRsidaqBblv+Hi14v3ZqL70AL47i83MJ72pGTPx0pylpIOJMCReNeCF
BoMfd15LfDFbkVhosTPTmo50Wd0=
Received: by filter0178p1las1.sendgrid.net with SMTP id filter0178p1las1-26653-5A90DBCE-A
2018-02-24 03:28:14.420927542 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16])
by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id JG8c_WKnRU-zMxJcigLXCA
for <hello@salmanwaheed.info>; Sat, 24 Feb 2018 03:28:14.311 +0000 (UTC)
Date: Sat, 24 Feb 2018 03:28:14 +0000 (UTC)
From: React Native Bot <notifications@github.com>
Reply-To: facebook/react-native <reply@reply.github.com>
To: facebook/react-native <react-native@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <facebook/react-native/issue/17743/issue_event/1490267860@github.com>
In-Reply-To: <facebook/react-native/issues/17743@github.com>
References: <facebook/react-native/issues/17743@github.com>
Subject: Re: [facebook/react-native] ListHeaderComponent should not be
considered the top of a list view (#17743)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5a90dac0f04_47a13fd37163af2c2099f1";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: react-native-bot
X-GitHub-Recipient: salmanwaheed
X-GitHub-Reason: subscribed
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post: <mailto:reply@reply.github.com>
List-Unsubscribe: <mailto:unsub+00ef1b38aa68d8dab7b891a04f5317bcb02d98b146f4823f92cf0000000116a89cbf92a169ce1161e4d0@reply.github.com>,
<https://github.com/notifications/unsubscribe/AO8bONevxf2Oaa0plJA2uVOUgmPnX1IXks5tX4C_gaJpZM4RtGpl>
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: hello@salmanwaheed.info
X-SG-EID: 92ws1MVnlto3blxqXlf5goB0ee0kdDGWR6vcWx8d64/2QMgynietcDboB330rDeJs7xWNTqevGf/XC
dnW036bwiV2ZIh6QYAx/wnYiJ0qLcXH8D6lhIGCfeKSm+aeEoJYDpXAKFL6G6Z4JBkPdJPUdQLTADG
1STONi2Zml1qLI4DtWMegD3XWD7rF2z8+IsYdETy+HPAaoGkrUWlAZTqqwEOndsXdJByAZN4YzvIrz
g=
X-Spam-Status: No, score=-0.0
X-Spam-Score: 0
X-Spam-Bar: /
X-Ham-Report: Spam detection software, running on the system "box1177.bluehost.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
root\@localhost for details.
Content preview: Closed #17743. -- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: #17743 (comment)
[...]
Content analysis details: (-0.0 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked.
See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information.
[URIs: github.com]
-0.5 SPF_PASS SPF: sender matches SPF record
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
1.3 HTML_IMAGE_ONLY_24 BODY: HTML: images with 2000-2400 bytes of words
0.0 HTML_MESSAGE BODY: HTML included in message
2.5 DCC_CHECK No description available.
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid
-1.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)
[167.89.101.199 listed in wl.mailspike.net]
-0.8 RCVD_IN_MSPIKE_WL Mailspike good senders
-1.5 AWL AWL: Adjusted score from AWL reputation of From: address
X-Spam-Flag: NO
----==_mimepart_5a90dac0f04_47a13fd37163af2c2099f1
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #17743.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#17743 (comment)
----==_mimepart_5a90dac0f04_47a13fd37163af2c2099f1
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>Closed <a href="#17743" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="291628240" data-permission-text="Issue title is private" data-url="#17743">#17743</a>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#17743 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AO8bOApTQPdZtp1KfPZNtKggYK6crV69ks5tX4DAgaJpZM4RtGpl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AO8bOAaL39HqV9m6QDY42-1SZFCJ1zH-ks5tX4DAgaJpZM4RtGpl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="#17743 (comment)"></link>
<meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/facebook/react-native","title":"facebook/react-native","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/facebook/react-native"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #17743."}],"action":{"name":"View Issue","url":"#17743 (comment)"}}}</script>
----==_mimepart_5a90dac0f04_47a13fd37163af2c2099f1--
|
Still a thing in v0.53.0. New issue: #18083 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Ran Commands
One of our bots successfully processed a command.
Stale
There has been a lack of activity on this issue and it may be closed soon.
Is this a bug report?
Depends on whether this is intended behavior.
Have you read the Contributing Guidelines?
Yes.
Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 9.4.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.52.0 => 0.52.0
Target Platform: iOS (11.2)
Steps to Reproduce
SectionList
ListHeaderComponent
to theSectionList
Expected Behavior
The
ListHeaderComponent
would initially be hidden, and would only be revealed by scrolling up, similar to a search or filter bar on iOS. Scrolling to the top of the list (for example by tapping the status bar) would scroll to the top of the first item in the list, not to the top of the header component.Actual Behavior
The
ListHeaderComponent
is rendered as if it were the first item in the list, and tapping the status bar scrolls to the top of the header component. I assume this is not the intended behavior, since the same can be achieved by using a different section on top of the list view with its ownrenderItem
function. If theListHeaderComponent
is implemented the way I expected, it would make it much easier to implement custom search bars, filter bars, and the like.Reproducible Demo
https://snack.expo.io/BJDvzFwBz
The text was updated successfully, but these errors were encountered: