Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with own configuration in wrong Build/Products folder #17650

Closed
lukaszgoworko opened this issue Jan 18, 2018 · 3 comments
Closed

Build with own configuration in wrong Build/Products folder #17650

lukaszgoworko opened this issue Jan 18, 2018 · 3 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@lukaszgoworko
Copy link

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment:

OS: macOS High Sierra 10.13.2
Node: 9.3.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 2.3 AI-162.3764568

Packages: (wanted => installed)

react: 16.0.0 => 16.0.0
react-native: 0.50.3 => 0.50.3

dependencies
"apisauce": "^0.14.1",
"babel-core": "^6.26.0",
"babel-plugin-transform-builtin-extend": "^1.1.2",
"hoist-non-react-statics": "^2.3.1",
"immutability-helper": "^2.4.0",
"lodash": "^4.17.4",
"moment": "^2.19.1",
"prop-types": "^15.6.0",
"react": "16.0.0",
"react-native": "0.50.3",
"react-native-config": "^0.10.0",
"react-native-device-info": "^0.12.1",
"react-native-elements": "^0.16.0",
"react-native-fetch-blob": "^0.10.8",
"react-native-fs": "^2.9.6",
"react-native-html-to-pdf": "^0.4.0",
"react-native-icon-badge": "^1.1.3",
"react-native-message-bar": "^2.0.1",
"react-native-offline": "^3.2.0",
"react-native-print": "^0.3.0",
"react-native-radio-buttons": "^1.0.0",
"react-native-router-flux": "4.0.0-beta.24",
"react-native-sha256": "^1.1.1",
"react-native-vector-icons": "^4.4.0",
"react-navigation": "^1.0.0-beta.15",
"react-redux": "^5.0.5",
"redux": "^3.7.0",
"redux-persist": "^5.2.0",
"redux-thunk": "^2.2.0",
"tcomb-form-native": "^0.6.8",
"uuid": "^3.1.0"
devDependencies
"babel-eslint": "^8.0.1",
"babel-jest": "21.2.0",
"babel-preset-react-native": "4.0.0",
"eslint": "^4.9.0",
"eslint-config-airbnb": "^16.1.0",
"eslint-plugin-flowtype": "^2.39.0",
"eslint-plugin-import": "^2.8.0",
"eslint-plugin-jsx-a11y": "^6.0.2",
"eslint-plugin-react": "^7.4.0",
"flow-bin": "^0.56.0",
"jest": "21.2.1",
"nock": "^9.0.14",
"react-test-renderer": "16.0.0-beta.5",
"redux-devtools": "^3.4.0",
"redux-mock-store": "^1.3.0"

Target Platform: iOS (8.0)

Steps to Reproduce

Creating new configuration and scheme in Xcode with own icons, name, and app-ID. Change debug configuration.

(Write your steps here:)

  1. Dublicate Configuration "Release" => Named Staging
  2. Add new IconsSets => AppIconStaging and AppIconDebug
  3. Change Target Build Settings
    1. ASSETCATALOG_COMPILER_APPICON_NAME
      • Debug: AppIconDebug
      • Staging: AppIconStaging
      • Release: AppIconRelease
    2. PRODUCT_BUNDLE_IDENTIFIER
      • different for every configuration
    3. PRODUCT_NAME
      • different for every configuration
  4. Dublicate Scheme => named: ProjectDebug and ProjectStaging
  5. Edit Schemes
    1. Set Build Settings for Run, Profile and Archive
      • ProjectDebug => Debug
      • ProjectStaging => Staging

At this Point trying to run ProjectStaging on Simulator fails because the build fails.
I have noticed, that when building ProjectStaging with Staging configuration on an fresh git clone of my project, some files are build in ios/build/Build/Products/Release-iphonesimulator.

Because of this files the build fails, they can't be found in the Staging-iphonesimulator folder.

There are some links to solutions by changing some build settings for Staging configuration

Changing: Header Search Paths, Framework Search Paths, Library Search Paths and User Header Search Paths to
$(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME)

Now all scheme builds failing when trying to run from Xcode:
/Volumes/Workspace/Projects/Project/ios/ProjectTests/ProjectTests.m:11:9: 'XCTest/XCTest.h' file not found

Running from console:
node node_modules/react-native/local-cli/cli.js run-ios --device --scheme ProjectStaging --configuration Staging
Build fails because of same issue, but App is installed and running well (cant find any errors for now)

Building archive always working

Expected Behavior

Project files for a configuration are in their own folder, so the build is always ok.

Actual Behavior

Correct Build with all files in the right place
@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to Contribute • What to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 24, 2018
@salmanwaheed
Copy link

salmanwaheed commented Feb 24, 2018 via email

@lukaszgoworko
Copy link
Author

now I updated my react native

Environment:
OS: macOS High Sierra 10.13.5
Node: 10.4.0
Yarn: 1.7.0
npm: 6.1.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 2.3 AI-162.3764568

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: ^0.55.4 => 0.55.4

So this is still a problem in newer.
Should I create a new issue or can this be open again?

@lukaszgoworko lukaszgoworko mentioned this issue Jun 27, 2018
Closed
@facebook facebook locked as resolved and limited conversation to collaborators Feb 24, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@salmanwaheed @lukaszgoworko @react-native-bot