Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NavigatorIOS] Move to OSSLibraries folder #1519

Closed
brentvatne opened this issue Jun 5, 2015 · 10 comments
Closed

[NavigatorIOS] Move to OSSLibraries folder #1519

brentvatne opened this issue Jun 5, 2015 · 10 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@brentvatne
Copy link
Collaborator

In order to be able to better support community contributions and make clear that this library is not currently a priority for Facebook, the plan is to try moving this component to a separate directory that is not managed in the same way by the sync process.

  1. Move NavigatorIOS.ios.js to new folder OSSLibraries/NavigatorIOS/NavigatorIOS.ios.js
  2. RCTNavigator code to that folder, and in new Xcode project
@brentvatne brentvatne added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jun 5, 2015
@grabbou
Copy link
Contributor

grabbou commented Jun 8, 2015

@brentvatne what about keeping the structure inside OSSLibraries somehow similar to the Libraries so it's easier to just move around instead of investigating the whole folder from scratch?

@jsierles
Copy link
Contributor

What about a separate repository?

@brentvatne
Copy link
Collaborator Author

@grabbou - makes sense, so OSSLibraries/Components/NavigatorIOS?

@brentvatne
Copy link
Collaborator Author

@jsierles - @ide @vjeux and I discussed this and it may happen eventually but at the moment it would complicate things a bit too much on the Facebook end, so this is a step towards that

@jsierles
Copy link
Contributor

Sounds good!

El jue., 11 jun. 2015 a las 19:43, Brent Vatne (notifications@github.com)
escribió:

@jsierles https://github.com/jsierles - @ide https://github.com/ide
@vjeux https://github.com/vjeux and I discussed this and it may happen
eventually but at the moment it would complicate things a bit too much on
the Facebook end, so this is a step towards that


Reply to this email directly or view it on GitHub
#1519 (comment)
.

@grabbou
Copy link
Contributor

grabbou commented Jun 11, 2015

@brentvatne - Yes. This kind of stuff. So it's possible to move other bits as well (currently there are none, but who knows ;) ). Anyway, will send over something by the end of the week and then we can discuss the structure further.

@brentvatne
Copy link
Collaborator Author

@grabbou - interested in doing this still?

@grabbou
Copy link
Contributor

grabbou commented Sep 13, 2015

Thanks for reminding. Yep, I am going to have some time this week to get few entry-level issues done :)

@grabbou
Copy link
Contributor

grabbou commented Sep 28, 2015

Will land today!

@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/navigatorios-move-to-osslibraries-folder

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.

Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is focused on performance.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants