Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run tvOS target for newly generated RN project #14613

Closed
vrudikov opened this issue Jun 19, 2017 · 22 comments
Closed

Can't run tvOS target for newly generated RN project #14613

vrudikov opened this issue Jun 19, 2017 · 22 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@vrudikov
Copy link

vrudikov commented Jun 19, 2017

Description

Basic iOS target runs successfully
I've created basic RN project with the help of react-native-cli and tried to run tvOS target, but got the following issue:

AppleTvSample/node_modules/react-native/ReactCommon/jschelpers/Value.cpp:3:10: 'folly/json.h' file not found

!!!RNTester application fails for the tvOS target too with the error above

Reproduction Steps

> react-native init sample_program
> cd sample_program
> open ios/sample_program.xcodeproj
> change Run Target to tvOS. Run it

Sample Code

AppleTvSample

Solution

Can't say for sure, because i'm not so familiar with XCode and Objective-C

Additional Information

  • React Native version: 0.45.1
  • react-native-cli: 2.0.1
  • Platform: tvOS
  • Development Operating System: macOS 10.11.6
  • Build tools: Xcode 8.2.1
@vrudikov vrudikov changed the title Can't run tvOS target for basic RN ios project Can't run tvOS target for basic RN project Jun 19, 2017
@vrudikov vrudikov changed the title Can't run tvOS target for basic RN project Can't run tvOS target for newly generated RN project Jun 19, 2017
@speedandfunction-anri
Copy link

speedandfunction-anri commented Jun 21, 2017

+1

  • react-native-cli: 2.0.1
  • react-native: 0.45.1
  • Platform: tvOS
  • Development Operating System: macOS 10.11.6
  • Build tools: Xcode 8.3.3 (8E3004b)

@speedandfunction-helen
Copy link

+1

1 similar comment
@miladebadi
Copy link

+1

@altaywtf
Copy link

altaywtf commented Jun 23, 2017

+1 😢

RNTester in this repo works fine but could not run fresh generated project via CLI.

  • react-native-cli: 2.0.1
  • react-native: 0.45.1
  • Platform: tvOS
  • Development Operating System: macOS 10.12.5
  • Build tools: Xcode 8.3.3 (8E3004b)

@altaywtf
Copy link

altaywtf commented Jun 23, 2017

@vrudikov, @speedandfunction-anri, @speedandfunction-helen, @knot123 hi guys.

it's confusing as hell but creating and ejecting an app with create-react-native-app resolved this one for me.

  • npm i create-react-native-app -g
  • create-react-native-app MyAwesomeProject
  • cd MyAwesomeProject
  • npm run eject

lulz 😅

@vrudikov
Copy link
Author

@altayaydemir Cool! Thanks for sharing!

@miladebadi
Copy link

miladebadi commented Jun 23, 2017

@altayaydemir I tried but same error appears.

'folly/json.h' file not found

@ndcollins
Copy link

@knot123 @altayaydemir I also get the same error that 'folly/json.h' file not found.

@vrudikov
Copy link
Author

@ndcollins @knot123 Hi, all. It works for me. Guys, please post your environment specs as I did above

@ndcollins
Copy link

ndcollins commented Jun 24, 2017

@vrudikov Identical environment from what I can tell

react-native-cli: 2.0.1
react-native: 0.45.1
Platform: tvOS
Development Operating System: macOS 10.12.5
Build tools: Xcode 8.3.3 (8E3004b)
Yarn: 0.24.6
Node: 6.10.1
NPM: 4.6.1

@altaywtf
Copy link

well, hello again. #14613 (comment) is worked for me once. but doesn't work now 🤔

I guess that is a

double lulz 😅

situation

@vrudikov
Copy link
Author

Strange, but yes. Stopped working for me too. What i see is that there some difference between jschelpers and jschelpers-tvOS targets. But can't understand what is that difference. Both projects share the same Target Dependency: third-party(React)

@vrudikov vrudikov reopened this Jun 26, 2017
@vrudikov
Copy link
Author

vrudikov commented Jun 26, 2017

So here is the difference between working project(right) and failing(left)
As all collaborators here both times i just used altayaydemir workaround

image

@joduss
Copy link

joduss commented Jul 5, 2017

Any news? I'm having the same issue

react-native-cli: 2.0.1
react-native: 0.45.1
Build tools: Xcode 8.3.3
NPM: 4.6.1
Yarn: 0.27.5
Development Operating System: 10.12.5

@joduss
Copy link

joduss commented Jul 6, 2017

I created the projet by mistake in /usr/local/Cellar/node/8.1.3/bin/ and it is working. Certainly something to do with permissions.

@calebsmithdev
Copy link

@joduss could you provide more information on what you did? I am having the same issue, but my folder is within my user library, so I feel like i shouldn't have any permission issues.

@joduss
Copy link

joduss commented Jul 6, 2017

I tried to remove node, yarn etc nothing changed. Until I did the react-native init in the folder I mentioned above.
So it could weird permissions or something not supported in the path. I didn't try in other locations.

@Maxwell2022
Copy link

Maxwell2022 commented Jul 18, 2017

in my case, it 'folly/dynamic.h' that is missing, brand new project:
I've also ejected to project, yarn eject

create-react-native-app version: 0.0.6
react-native: ^0.45.1


Update: After having successfully built the iPhone app, now I get the same error:
'folly/json.h' file not found

Also, I'm building the app from xcode directly

@ndcollins
Copy link

This issue appears to now be resolved. Now if you run react-native init the project is generated using react-native 0.46.4 in which this issue appears to be fully resolved.

@calebsmithdev
Copy link

Can confirm - updated to the lasest version of react-native and I am good to go.

@Maxwell2022
Copy link

humm, I just realised that the documented way to start a project (ie. create-react-native-app) is using expo, and expo is not using the latest version of RN by default.

Really annoying...

@hramos hramos added the Icebox label Sep 21, 2017
@hramos
Copy link
Contributor

hramos commented Sep 21, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Sep 21, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests