[Android] Focus is removed from TextInput when Talkback is enabled

[oargaruna]

Description

Our project is a hybrid of React Native modules and native UI. We are adding accessibility to our App and are hitting a weird issue with Talkback in TextInput:

If there is any clickable element before a TextInput in the view hierarchy, double tapping to add focus to the TextInput using Talkback sends the focus to the clickable element before it.

Reproduction

I have been able to reproduce the bug in a sample app: https://github.com/oargaruna/TextInputTalkback

1. Deploy the App on an Android device
2. Enable Talkback (from Settings -> Accessibility) and open the Sample App
3. Tap once on the TextInput to give it Talkback focus
4. Tap twice to try to get the keyboard to come up

We expect the keyboard to show up with focus on the TextInput, but the focus jumps to the TouchableOpacity element defined before it.

If the TouchableOpacity element is removed, this behaviour is not reproducible.

Additional Information

• React Native version: 0.41.1
• Platform: Android

[JasonWang-MS]

Same issue for me. Any solution?

[hramos]

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

• Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
• If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
• Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

[projetolead]

This is still happening to me on RN 0.49.3. Any workarounds?

[lelandrichardson]

Reopening this as it appears to be affecting us as well.

[backwardok]

Looks like this might be a dupe of #17042 ?

[haitaoli]

The issue is caused by this line of code:

react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Line 202 in c9ff0bc

return false;

It's been there forever. I guess it means the focus is always controlled by JS code. But when TalkBack is enabled the focus needs to be set directly.

[haitaoli]

Found some comments in code:

  // This component is controlled, so we want it to get focused only when JS ask it to do so.
  // Whenever android requests focus (which it does for random reasons), it will be ignored.

I wonder if this is still an issue in recent Android versions.

[oargaruna]

The issue is not reproducible in 0.51.

[haitaoli]

@oargaruna this only happens on Android 6.