-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Focus is removed from TextInput when Talkback is enabled #12205
Comments
Same issue for me. Any solution? |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
This is still happening to me on RN 0.49.3. Any workarounds? |
Reopening this as it appears to be affecting us as well. |
Looks like this might be a dupe of #17042 ? |
The issue is caused by this line of code: react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java Line 202 in c9ff0bc
It's been there forever. I guess it means the focus is always controlled by JS code. But when TalkBack is enabled the focus needs to be set directly. |
Found some comments in code:
I wonder if this is still an issue in recent Android versions. |
The issue is not reproducible in 0.51. |
@oargaruna this only happens on Android 6. |
It is not working on Android 8.0 on latest version of react native as well. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
still an issue in RN v0.54 and I'm currently testing on an Android 8.1 device. definitely not device specific when looking at the code linked by @haitaoli |
This is still affecting Android 8.0 - RN 0.57.1 Do we have any context for the hack? We'd prefer not to maintain a fork, especially since that was explicitly referenced in the AirBnbB posts : P |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
still an issue, bot |
Hello, I'm currently using Android 8.1.0 with RN 0.51.0 and RN 0.58.3 (two apps) and both have the same problem when talkback is enabled, the keyboard does not appear when autofocus is in the textinput. |
I have the same problem here. I'm using RN 0.59.3 |
Double tap and hold to long press on TextInput keyboard will come up, it's default behaviour. Works for me |
@dishantwalia that is not default behaviour. everything should be accessible by double tapping.
you should make sure that whatever you're testing this against is actually an input field and not a wrapper. for instance, if you use the floating label input field type provided by Native Base, you can access the input field by double tapping on the wrapper |
I found a possible solution for this issue #24519 |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
still an issue |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
still not fixed |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
Description
Our project is a hybrid of React Native modules and native UI. We are adding accessibility to our App and are hitting a weird issue with Talkback in TextInput:
If there is any clickable element before a TextInput in the view hierarchy, double tapping to add focus to the TextInput using Talkback sends the focus to the clickable element before it.
Reproduction
I have been able to reproduce the bug in a sample app: https://github.com/oargaruna/TextInputTalkback
We expect the keyboard to show up with focus on the TextInput, but the focus jumps to the TouchableOpacity element defined before it.
If the TouchableOpacity element is removed, this behaviour is not reproducible.
Additional Information
The text was updated successfully, but these errors were encountered: