-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[cli] spawn xterm on linux to run the packager
Also use ANDROID_HOME env var when running adb.
- Loading branch information
Showing
2 changed files
with
17 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,14 +5,21 @@ var child_process = require('child_process'); | |
|
||
module.exports = function(newWindow) { | ||
if (newWindow) { | ||
child_process.spawnSync('open', [ | ||
path.resolve(__dirname, '..', 'packager', 'launchPackager.command') | ||
]); | ||
var launchPackagerScript = | ||
path.resolve(__dirname, '..', 'packager', 'launchPackager.command'); | ||
if (process.platform === 'darwin') { | ||
child_process.spawnSync('open', [launchPackagerScript]); | ||
} else if (process.platform === 'linux') { | ||
child_process.spawn( | ||
'xterm', | ||
['-e', 'sh', launchPackagerScript], | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
foghina
Author
Contributor
|
||
{detached: true}); | ||
} | ||
} else { | ||
child_process.spawn('sh', [ | ||
path.resolve(__dirname, '..', 'packager', 'packager.sh'), | ||
'--projectRoots', | ||
process.cwd(), | ||
], {stdio: 'inherit'}); | ||
} | ||
}; | ||
}; |
1 comment
on commit f6ec854
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you!
Do we still call
launchPackager.command
on Linux though?