Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix RNTesterUnitTests failure (#22658)
Summary: Pull Request resolved: #22658 Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running `scripts/objc-test-ios.sh test` seen in Circle CI. See D9875409 for a related diff (78fcf7c in open source). Without this diff, `scripts/objc-test-ios.sh test` would fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704): ``` � ld: symbol(s) not found for architecture x86_64 � clang: error: linker command failed with exit code 1 (use -v to see invocation) Testing failed: "_JSObjectGetPrototype", referenced from: "_JSObjectSetPrototype", referenced from: "_JSPropertyNameAccumulatorAddName", referenced from: "_JSObjectCopyPropertyNames", referenced from: "_JSContextGetGlobalObject", referenced from: "_JSValueMakeString", referenced from: "_JSValueIsNumber", referenced from: "_JSClassCreate", referenced from: "_JSObjectGetPropertyAtIndex", referenced from: "_JSObjectMakeArray", referenced from: "_JSEvaluateScript", referenced from: "_JSValueIsUndefined", referenced from: "_JSPropertyNameArrayGetCount", referenced from: "_JSPropertyNameArrayGetNameAtIndex", referenced from: "_JSPropertyNameArrayRelease", referenced from: "_JSValueMakeUndefined", referenced from: "_JSValueMakeNull", referenced from: "_JSStringCreateWithUTF8CString", referenced from: "_JSObjectSetProperty", referenced from: "_JSObjectHasProperty", referenced from: "_kJSClassDefinitionEmpty", referenced from: "_JSObjectIsFunction", referenced from: "_JSValueIsBoolean", referenced from: "_JSValueIsInstanceOfConstructor", referenced from: "_JSValueIsObjectOfClass", referenced from: "_JSValueToNumber", referenced from: "_JSGlobalContextRelease", referenced from: "_JSValueToBoolean", referenced from: "_JSValueIsArray", referenced from: "_JSValueMakeNumber", referenced from: "_JSObjectSetPrivate", referenced from: "_JSValueIsNull", referenced from: "_JSObjectSetPropertyAtIndex", referenced from: "_JSValueIsObject", referenced from: "_JSValueMakeBoolean", referenced from: "_JSValueUnprotect", referenced from: "_JSValueToStringCopy", referenced from: "_JSObjectGetProperty", referenced from: "_JSValueToObject", referenced from: "_JSObjectGetPrivate", referenced from: "_JSStringRelease", referenced from: "_JSGlobalContextRetain", referenced from: "_JSStringIsEqual", referenced from: "_JSStringGetMaximumUTF8CStringSize", referenced from: "_JSObjectCallAsFunction", referenced from: "_JSStringGetUTF8CString", referenced from: "_JSValueProtect", referenced from: "_JSValueIsString", referenced from: "_JSStringRetain", referenced from: "_JSObjectMake", referenced from: "_JSGlobalContextCreateInGroup", referenced from: "_JSObjectCallAsConstructor", referenced from: Linker command failed with exit code 1 (use -v to see invocation) Testing cancelled because the build failed. ** TEST FAILED ** ``` Reviewed By: fkgozali Differential Revision: D13474936 fbshipit-source-id: b12ddd6dcb95a7a588463d74cc0798dd591bdd78
- Loading branch information