Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update types for autoComplete prop. (#25549)
Summary: I believe there's a mismatch between the type definitions and the expected prop in Android for `TextInput`'s `autoComplete` prop. * Android is expecting `autoComplete`. * JS types are expecting `autoCompleteType`. * Latest documentation documents `autoCompleteType`. Prop added here: 179d490 This change updates the JS types to match what Android is expecting (`autoComplete`). Can update documentation if this is the approach we'd prefer (rather than updating Android to expect `autoCompleteType`). ## Changelog [Javascript] [Fixed] - Update types for `TextInput`'s `autoComplete` prop. Pull Request resolved: #25549 Test Plan: Before: * Pass invalid value to `TextInput`'s `autoComplete` prop, see no type errors on JS side, and Android blows up with: ```sh Invalid autocomplete option: foobar updateViewProp ViewManagersPropertyCache.java:95 setProperty ViewManagerPropertyUpdater.java:132 updateProps ViewManagerPropertyUpdater.java:51 updateProperties ViewManager.java:37 ``` After: * Pass invalid value to `TextInput`'s `autoComplete` prop, see PropType warning for `autoComplete` prop. Differential Revision: D16220809 Pulled By: mdvacca fbshipit-source-id: e25e198cbcbe721c8d71f069bba293856bf5f36d
- Loading branch information