Refactor remaining forEachPackage call sites (#43112)

Summary: Pull Request resolved: #43112 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53942028 fbshipit-source-id: 335bff3c3a31026bae7140fac1d1a6aae23a0f1e
facebook · Feb 20, 2024 · d6bf51c · d6bf51c
1 parent 4ecf57e
commit d6bf51c
Show file tree

Hide file tree

Showing 15 changed files with 370 additions and 480 deletions.
diff --git a/scripts/e2e/init-template-e2e.js b/scripts/e2e/init-template-e2e.js
@@ -13,7 +13,7 @@
 
 const {retry} = require('../circleci/retry');
 const {REPO_ROOT} = require('../consts');
-const forEachPackage = require('../monorepo/for-each-package');
+const {getPackages} = require('../utils/monorepo');
 const {
   VERDACCIO_SERVER_URL,
   VERDACCIO_STORAGE_PATH,
@@ -22,6 +22,7 @@ const {
 const {parseArgs} = require('@pkgjs/parseargs');
 const chalk = require('chalk');
 const {execSync} = require('child_process');
+const path = require('path');
 
 const config = {
   options: {
@@ -86,26 +87,28 @@ async function initNewProjectFromSource(
     console.log('\nDone ✅');
 
     console.log('Publishing packages to local npm proxy\n');
-    forEachPackage(
-      (packageAbsolutePath, packageRelativePathFromRoot, packageManifest) => {
-        if (packageManifest.private) {
-          return;
-        }
-
-        const desc = `${packageManifest.name} (${packageRelativePathFromRoot})`;
-        process.stdout.write(
-          `${desc} ${chalk.dim('.').repeat(Math.max(0, 72 - desc.length))} `,
-        );
-        execSync(
-          `npm publish --registry ${VERDACCIO_SERVER_URL} --access public`,
-          {
-            cwd: packageAbsolutePath,
-            stdio: verbose ? 'inherit' : [process.stderr],
-          },
-        );
-        process.stdout.write(chalk.reset.inverse.bold.green(' DONE ') + '\n');
-      },
-    );
+    const packages = await getPackages({
+      includeReactNative: false,
+      includePrivate: false,
+    });
+
+    for (const {path: packagePath, packageJson} of Object.values(packages)) {
+      const desc = `${packageJson.name} (${path.relative(
+        REPO_ROOT,
+        packagePath,
+      )})`;
+      process.stdout.write(
+        `${desc} ${chalk.dim('.').repeat(Math.max(0, 72 - desc.length))} `,
+      );
+      execSync(
+        `npm publish --registry ${VERDACCIO_SERVER_URL} --access public`,
+        {
+          cwd: packagePath,
+          stdio: verbose ? 'inherit' : [process.stderr],
+        },
+      );
+      process.stdout.write(chalk.reset.inverse.bold.green(' DONE ') + '\n');
+    }
     console.log('\nDone ✅');
 
     console.log('Running react-native init without install');