Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't return empty string for
accessibilityLabel
for RCTView
Summary: In case `RCTView` had no subviews, `RCTRecursiveAccessibilityLabel` was returning an empty string rather than nil. I've noticed that https://fburl.com/i95iynxi returns empty string as well. Shall we change it there as well? Reviewed By: shergin Differential Revision: D15337865 fbshipit-source-id: 8e38a88321f3dcfdf35a38d43fdbe4f5118796f1
- Loading branch information
d4ff5ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @rigdern ,
just heads up, I made a small change to
RCTRecursiveAccessibilityLabel
because it was returning an empty string so often it populatedaccessibilityLabel
with @"".d4ff5ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up.