-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor generate-artifacts-executor.js: delete handleLibrariesFromRe…
…actNativeConfig (#41654) Summary: Pull Request resolved: #41654 This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Reviewed By: cipolleschi Differential Revision: D51308595 fbshipit-source-id: 97841a3a8c295aa717c577bb188d48373b04ba38
- Loading branch information
1 parent
ef9c164
commit ca39a11
Showing
2 changed files
with
0 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters