Skip to content

Commit

Permalink
Remove redundant property from ImageRequest
Browse files Browse the repository at this point in the history
Summary:
Changelog: [internal]

`moved_`, introduced in D8526571 (979ea20), no longer servers its purpose.
Let's remove it.

Reviewed By: JoshuaGross

Differential Revision: D24475715

fbshipit-source-id: 162d1fc4ed3d4a67885d8f140904dd80763dcaa0
  • Loading branch information
sammy-SC authored and facebook-github-bot committed Oct 23, 2020
1 parent 16044b3 commit bfbd841
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions ReactCommon/react/renderer/imagemanager/ImageRequest.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ class ImageRequest final {
* Function we can call to cancel image request (see destructor).
*/
std::function<void(void)> cancelRequest_;

/*
* Indicates that the object was moved and hence cannot be used anymore.
*/
bool moved_{false};
};

} // namespace react
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ ImageRequest::ImageRequest(ImageRequest &&other) noexcept
: imageSource_(std::move(other.imageSource_)),
telemetry_(std::move(other.telemetry_)),
coordinator_(std::move(other.coordinator_)) {
other.moved_ = true;
other.coordinator_ = nullptr;
other.cancelRequest_ = nullptr;
other.telemetry_ = nullptr;
Expand Down

0 comments on commit bfbd841

Please sign in to comment.