Skip to content

Commit

Permalink
fix: build settings for custom build configuration (#43780)
Browse files Browse the repository at this point in the history
Summary:
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185

Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185

This now applies the setting to every configuration ending with `Debug`

## Changelog:

[IOS] [CHANGED] - fix: build settings for custom build configuration

Pull Request resolved: #43780

Reviewed By: dmytrorykun

Differential Revision: D55688996

Pulled By: cipolleschi

fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
  • Loading branch information
jblarriviere authored and facebook-github-bot committed Apr 3, 2024
1 parent 558f6ba commit bcac3c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/scripts/cocoapods/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def self.add_build_settings_to_pod(installer, settings_name, settings_value, tar
installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
if pod_name.to_s == target_pod_name
target_installation_result.native_target.build_configurations.each do |config|
if configuration == nil || (configuration != nil && configuration == config.name)
if configuration == nil || (configuration != nil && config.name.include?(configuration))
config.build_settings[settings_name] ||= '$(inherited) '
config.build_settings[settings_name] << settings_value
end
Expand Down

0 comments on commit bcac3c4

Please sign in to comment.