Skip to content

Commit

Permalink
fix method overriding when using native animations
Browse files Browse the repository at this point in the history
Reviewed By: davidaurelio

Differential Revision: D3683921

fbshipit-source-id: 8be9437c1f2625c69d0e07142010494a01f52005
  • Loading branch information
foghina authored and Facebook Github Bot 8 committed Aug 9, 2016
1 parent 335132a commit b7903e4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Libraries/Animated/src/AnimatedImplementation.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Animation {
NativeAnimatedAPI.stopAnimation(this.__nativeId);
}
}
_getNativeAnimationConfig(): any {
__getNativeAnimationConfig(): any {
// Subclasses that have corresponding animation implementation done in native
// should override this method
throw new Error('This animation type cannot be offloaded to native');
Expand All @@ -114,7 +114,7 @@ class Animation {
NativeAnimatedAPI.startAnimatingNode(
this.__nativeId,
animatedValue.__getNativeTag(),
this._getNativeAnimationConfig(),
this.__getNativeAnimationConfig(),
this.__debouncedOnEnd.bind(this)
);
}
Expand Down Expand Up @@ -253,7 +253,7 @@ class TimingAnimation extends Animation {
this._useNativeDriver = config.useNativeDriver !== undefined ? config.useNativeDriver : false;
}

_getNativeAnimationConfig(): any {
__getNativeAnimationConfig(): any {
var frameDuration = 1000.0 / 60.0;
var frames = [];
for (var dt = 0.0; dt < this._duration; dt += frameDuration) {
Expand Down Expand Up @@ -485,7 +485,7 @@ class SpringAnimation extends Animation {
this._friction = springConfig.friction;
}

_getNativeAnimationConfig() {
__getNativeAnimationConfig() {
return {
type: 'spring',
overshootClamping: this._overshootClamping,
Expand Down

0 comments on commit b7903e4

Please sign in to comment.