Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make hermes-executor-common a static lib (#32683)
Summary: I've been seeing a couple crashes related to missing hermes-executor-common.so, seems to happen on specific android versions, but can't repro. I investigated this so file more and noticed it is incorrectly linked as a static library here https://github.com/facebook/react-native/blob/b8f415eb6cdc0e0e7a7413b6f9defdcee304d9e8/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/Android.mk#L20. There doesn't seem to be any reason for this to be a shared lib so I changed it to be compiled as a static lib. ## Changelog [Android] [Fixed] - Make hermes-executor-common a static lib Pull Request resolved: #32683 Test Plan: - Verify there is no more hermes-executor-common-{release,debug}.so - Test locally in an app to make sure it build and run properly. - Verify that the crash happening on play store pre-launch report doesn't happen anymore. Reviewed By: ShikaSD Differential Revision: D32754968 Pulled By: cortinico fbshipit-source-id: cb57e2d81edb4cbdb1f003dab45c53e594a5a62a
- Loading branch information