Skip to content

Commit

Permalink
fix(e2e): add versions when installing appium drivers (#39275)
Browse files Browse the repository at this point in the history
Summary:
Right now we're fetching latests versions of drivers which isn't the best, we should always download the same versions.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[INTERNAL] - Add versions when installing Appium drivers.

Pull Request resolved: #39275

Test Plan: CI Green - (side note: if jobs `test_e2e_ios` and `test_e2e_android` are green it doesn't mean that they passed.)

Reviewed By: cipolleschi

Differential Revision: D49248778

Pulled By: NickGerleman

fbshipit-source-id: 5b114b7dc1172993afc4b02e9d3380afa9f03c40
  • Loading branch information
szymonrybczak authored and facebook-github-bot committed Sep 14, 2023
1 parent 3e7a873 commit 9d52767
Show file tree
Hide file tree
Showing 3 changed files with 142 additions and 2,305 deletions.
4 changes: 2 additions & 2 deletions .circleci/configurations/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ jobs:
- run:
name: Install appium drivers
command: |
appium driver install uiautomator2
appium driver install xcuitest
appium driver install uiautomator2@2.29.1
appium driver install xcuitest@4.32.10
- run:
name: Start Appium server
command: appium --base-path /wd/hub
Expand Down
3 changes: 0 additions & 3 deletions packages/rn-tester-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
"test-e2e": "node ./../../scripts/e2e/run-e2e-tests.js"
},
"devDependencies": {
"appium": "^2.0.0",
"appium-uiautomator2-driver": "^2.29.1",
"appium-xcuitest-driver": "^4.32.10",
"eslint": "^8.19.0",
"jest": "^29.6.3",
"webdriverio": "^7.32.0",
Expand Down
Loading

0 comments on commit 9d52767

Please sign in to comment.