Skip to content

Commit

Permalink
Reduce visibility of ReactImageDownloadListener
Browse files Browse the repository at this point in the history
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.

If you are using this class or interface please comment in this PR and we will restate the public access.

bypass-github-export-checks

changelog: [Android][Changed] Reducing visibility of ReactImageDownloadListener

Reviewed By: arushikesarwani94

Differential Revision: D49803289

fbshipit-source-id: 19d4c3403449dd9b928963b274362662375b7545
  • Loading branch information
mdvacca authored and facebook-github-bot committed Oct 9, 2023
1 parent fa1a29b commit 9582f98
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import com.facebook.drawee.drawable.ForwardingDrawable;
import javax.annotation.Nullable;

public class ReactImageDownloadListener<INFO> extends ForwardingDrawable
class ReactImageDownloadListener<INFO> extends ForwardingDrawable
implements ControllerListener<INFO> {

private static final int MAX_LEVEL = 10000;
Expand Down

1 comment on commit 9582f98

@rafaelmaeuer
Copy link

@rafaelmaeuer rafaelmaeuer commented on 9582f98 Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arushikesarwani94 This class is used in package iyegoroff/react-native-image-filter-kit#150 and this change breaks building the project on Android. Can you please revert this to public?

Please sign in to comment.