Update React Native codegen to support Partial as alias of $Partial

Summary: `Partial` is the new name of `$Partial` Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D43993220 fbshipit-source-id: 38e8a6bcfa559857b2ab88efee6b904b387bdc0d
facebook · Mar 15, 2023 · 7fee407 · 7fee407
1 parent 06b97ca
commit 7fee407
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/.../react-native-codegen/e2e/__test_fixtures__/modules/NativePartialAnnotationTurboModule.js b/.../react-native-codegen/e2e/__test_fixtures__/modules/NativePartialAnnotationTurboModule.js
@@ -18,14 +18,14 @@ export type SomeObj = {|
   b?: boolean,
 |};
 
-export type PartialSomeObj = $Partial<SomeObj>;
+export type PartialSomeObj = Partial<SomeObj>;
 
 export interface Spec extends TurboModule {
   +getSomeObj: () => SomeObj;
-  +getPartialSomeObj: () => $Partial<SomeObj>;
-  +getSomeObjFromPartialSomeObj: (value: $Partial<SomeObj>) => SomeObj;
+  +getPartialSomeObj: () => Partial<SomeObj>;
+  +getSomeObjFromPartialSomeObj: (value: Partial<SomeObj>) => SomeObj;
   +getPartialPartial: (
-    value1: $Partial<SomeObj>,
+    value1: Partial<SomeObj>,
     value2: PartialSomeObj,
   ) => SomeObj;
 }

diff --git a/packages/react-native-codegen/src/parsers/flow/modules/__test_fixtures__/fixtures.js b/packages/react-native-codegen/src/parsers/flow/modules/__test_fixtures__/fixtures.js
@@ -311,8 +311,8 @@ export type SomeObj = {|
 
 export interface Spec extends TurboModule {
   +getSomeObj: () => SomeObj;
-  +getPartialSomeObj: () => $Partial<SomeObj>;
-  +getSomeObjFromPartialSomeObj: (value: $Partial<SomeObj>) => SomeObj;
+  +getPartialSomeObj: () => Partial<SomeObj>;
+  +getSomeObjFromPartialSomeObj: (value: Partial<SomeObj>) => SomeObj;
 }
 
 export default TurboModuleRegistry.getEnforcing<Spec>('SampleTurboModule');
@@ -340,10 +340,10 @@ export type SomeObj = {|
   b?: boolean,
 |};
 
-export type PartialSomeObj = $Partial<SomeObj>;
+export type PartialSomeObj = Partial<SomeObj>;
 
 export interface Spec extends TurboModule {
-  +getPartialPartial: (value1: $Partial<SomeObj>, value2: PartialSomeObj) => SomeObj
+  +getPartialPartial: (value1: Partial<SomeObj>, value2: PartialSomeObj) => SomeObj
 }
 
 export default TurboModuleRegistry.getEnforcing<Spec>('SampleTurboModule');

diff --git a/packages/react-native-codegen/src/parsers/flow/modules/index.js b/packages/react-native-codegen/src/parsers/flow/modules/index.js
@@ -148,6 +148,7 @@ function translateTypeAnnotation(
         case 'Object': {
           return emitGenericObject(nullable);
         }
+        case 'Partial':
         case '$Partial': {
           throwIfPartialWithMoreParameter(typeAnnotation);