Skip to content

Commit

Permalink
enable unsafe addition check in xplat
Browse files Browse the repository at this point in the history
Summary:
With the release of 0.118 Flow now checks for unsafe additions between numbers and null/void. This enables this check in xplat.

```~/fbsource/fbcode/flow/tool add-comments --bin `which flow` --comment="//flowlint-next-line unsafe-addition=off" ~/fbsource/xplat/js```

`js1 test -u __tests__/flowconfig-sync-test.js`

Changelog: [Internal]

bypass-lint

Reviewed By: nmote

Differential Revision: D19823403

fbshipit-source-id: 1f059de6c9d973cda11930f1fadb485679d4ecec
  • Loading branch information
Daniel Sainati authored and facebook-github-bot committed Feb 11, 2020
1 parent acdaf51 commit 7bd1abe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ unsafe-getters-setters=warn
unnecessary-invariant=warn
signature-verification-failure=warn
deprecated-utility=error
unsafe-addition=error

[strict]
deprecated-type
Expand Down
1 change: 1 addition & 0 deletions .flowconfig.android
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ unsafe-getters-setters=warn
unnecessary-invariant=warn
signature-verification-failure=warn
deprecated-utility=error
unsafe-addition=error

[strict]
deprecated-type
Expand Down

0 comments on commit 7bd1abe

Please sign in to comment.