Skip to content

Commit

Permalink
fix(virtualized-lists): declare missing react peer dependency (#42947)
Browse files Browse the repository at this point in the history
Summary:
In setups with `pnpm`  `react-native/virtualized-lists` gets bundled incorrectly because of the following error:

`Module not found: Error: Can't resolve 'react'`

As 'react' is used inside of the package, it should declared explicitly, instead of being a phantom dependency.

## Changelog:

[GENERAL] [FIXED] - Declare missing peer dependency `react`

Pull Request resolved: #42947

Test Plan: not needed

Reviewed By: NickGerleman

Differential Revision: D53617462

Pulled By: cortinico

fbshipit-source-id: 19a8fed94263646b0af93339d5c014e629dfa6b1
  • Loading branch information
jbroma authored and facebook-github-bot committed Feb 11, 2024
1 parent 3582f43 commit 62c15ba
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/virtualized-lists/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"react-test-renderer": "18.2.0"
},
"peerDependencies": {
"react": "*",
"react-native": "*"
}
}

0 comments on commit 62c15ba

Please sign in to comment.