Skip to content

Commit

Permalink
Delete CoreFeatures::enableReportEventPaintTime
Browse files Browse the repository at this point in the history
Summary:
I'm deleting CoreFeatures::enableReportEventPaintTime because this feature flag has never been enabled since it was created 8+ months ago

changelog: [internal] internal

Differential Revision: D60134872
  • Loading branch information
mdvacca committed Jul 24, 2024
1 parent 4d4c6ce commit 5ab08c3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,6 @@ void EventPerformanceLogger::onEventProcessingEnd(EventTag tag) {
auto& entry = it->second;
entry.processingEndTime = timeStamp;

if (ReactNativeFeatureFlags::enableReportEventPaintTime()) {
// If reporting paint time, don't send the entry just yet and wait for the
// mount hook callback to be called
return;
}

const auto& name = entry.name;

performanceEntryReporter->logEventEntry(
Expand All @@ -163,10 +157,6 @@ void EventPerformanceLogger::onEventProcessingEnd(EventTag tag) {
void EventPerformanceLogger::shadowTreeDidMount(
const RootShadowNode::Shared& /*rootShadowNode*/,
double mountTime) noexcept {
if (!ReactNativeFeatureFlags::enableReportEventPaintTime()) {
return;
}

auto performanceEntryReporter = performanceEntryReporter_.lock();
if (performanceEntryReporter == nullptr) {
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,6 @@ Scheduler::Scheduler(
removeOutstandingSurfacesOnDestruction_ = reactNativeConfig_->getBool(
"react_fabric:remove_outstanding_surfaces_on_destruction_ios");
#endif

if (ReactNativeFeatureFlags::enableReportEventPaintTime()) {
uiManager->registerMountHook(*eventPerformanceLogger_);
}
}

Scheduler::~Scheduler() {
Expand Down

0 comments on commit 5ab08c3

Please sign in to comment.