chore: Add functionTypeAnnotation to codegen Parser class (#36468)

Summary:
This PR adds a  `functionTypeAnnotation`  function to the codegen Parser class and implements it in the Flow and TypeScript parsers as requested on #34872, refactoring the `throwIfModuleTypeIsUnsupported`  function to accept a `Parser` instead of a `ParserType` and use the newly created function instead of the `if (language)` logic.

## Changelog

[Internal] [Added] - Add `functionTypeAnnotation` to codegen Parser class

Pull Request resolved: #36468

Test Plan:
Run `yarn jest react-native-codegen` and ensure CI is green

![image](https://user-images.githubusercontent.com/11707729/224882017-2c31f326-047d-4c21-91e0-3396203ce1c5.png)

Reviewed By: cipolleschi

Differential Revision: D44056853

Pulled By: rshest

fbshipit-source-id: f22b9efe53df16f7916eb1a9cea8b9531f1194f5

packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js

@@ -554,73 +554,71 @@ describe('throwIfUntypedModule', () => {
 describe('throwIfModuleTypeIsUnsupported', () => {
   const hasteModuleName = 'moduleName';
   const property = {value: 'value', key: {name: 'name'}};
+  const flowParser = new FlowParser();
+  const typescriptParser = new TypeScriptParser();
+
   it("don't throw error if module type is FunctionTypeAnnotation in Flow", () => {
     const value = {type: 'FunctionTypeAnnotation'};
-    const language = 'Flow';
 
     expect(() => {
       throwIfModuleTypeIsUnsupported(
         hasteModuleName,
         property.value,
         property.key.name,
         value.type,
-        language,
+        flowParser,
       );
     }).not.toThrow(UnsupportedModulePropertyParserError);
   });
   it('throw error if module type is unsupported in Flow', () => {
     const value = {type: ''};
-    const language = 'Flow';
 
     expect(() => {
       throwIfModuleTypeIsUnsupported(
         hasteModuleName,
         property.value,
         property.key.name,
         value.type,
-        language,
+        flowParser,
       );
     }).toThrow(UnsupportedModulePropertyParserError);
   });
   it("don't throw error if module type is TSFunctionType in TypeScript", () => {
     const value = {type: 'TSFunctionType'};
-    const language = 'TypeScript';
 
     expect(() => {
       throwIfModuleTypeIsUnsupported(
         hasteModuleName,
         property.value,
         property.key.name,
         value.type,
-        language,
+        typescriptParser,
       );
     }).not.toThrow(UnsupportedModulePropertyParserError);
   });
   it("don't throw error if module type is TSMethodSignature in TypeScript", () => {
     const value = {type: 'TSMethodSignature'};
-    const language = 'TypeScript';
 
     expect(() => {
       throwIfModuleTypeIsUnsupported(
         hasteModuleName,
         property.value,
         property.key.name,
         value.type,
-        language,
+        typescriptParser,
       );
     }).not.toThrow(UnsupportedModulePropertyParserError);
   });
   it('throw error if module type is unsupported in TypeScript', () => {
     const value = {type: ''};
-    const language = 'TypeScript';
 
     expect(() => {
       throwIfModuleTypeIsUnsupported(
         hasteModuleName,
         property.value,
         property.key.name,
         value.type,
-        language,
+        typescriptParser,
       );
     }).toThrow(UnsupportedModulePropertyParserError);
   });

packages/react-native-codegen/src/parsers/error-utils.js

@@ -160,27 +160,15 @@ function throwIfModuleTypeIsUnsupported(
   propertyValue: $FlowFixMe,
   propertyName: string,
   propertyValueType: string,
-  language: ParserType,
+  parser: Parser,
 ) {
-  if (language === 'Flow' && propertyValueType !== 'FunctionTypeAnnotation') {
-    throw new UnsupportedModulePropertyParserError(
-      nativeModuleName,
-      propertyValue,
-      propertyName,
-      propertyValueType,
-      language,
-    );
-  } else if (
-    language === 'TypeScript' &&
-    propertyValueType !== 'TSFunctionType' &&
-    propertyValueType !== 'TSMethodSignature'
-  ) {
+  if (!parser.functionTypeAnnotation(propertyValueType)) {
     throw new UnsupportedModulePropertyParserError(
       nativeModuleName,
       propertyValue,
       propertyName,
       propertyValueType,
-      language,
+      parser.language(),
     );
   }
 }

packages/react-native-codegen/src/parsers/flow/parser.js

@@ -291,6 +291,10 @@ class FlowParser implements Parser {
       };
     });
   }
+
+  functionTypeAnnotation(propertyValueType: string): boolean {
+    return propertyValueType === 'FunctionTypeAnnotation';
+  }
 }
 
 module.exports = {

packages/react-native-codegen/src/parsers/parser.js

@@ -204,4 +204,11 @@ export interface Parser {
     tryParse: ParserErrorCapturer,
     cxxOnly: boolean,
   ): Array<$FlowFixMe>;
+
+  /**
+   * Given a propertyValueType, it returns a boolean specifying if the property is a function type annotation.
+   * @parameter propertyValueType: the propertyValueType.
+   * @returns: a boolean specifying if the property is a function type annotation.
+   */
+  functionTypeAnnotation(propertyValueType: string): boolean;
 }

packages/react-native-codegen/src/parsers/parserMock.js

@@ -209,4 +209,8 @@ export class MockedParser implements Parser {
       },
     ];
   }
+
+  functionTypeAnnotation(propertyValueType: string): boolean {
+    return propertyValueType === 'FunctionTypeAnnotation';
+  }
 }

packages/react-native-codegen/src/parsers/parsers-commons.js

@@ -328,7 +328,7 @@ function buildPropertySchema(
     property.value,
     key.name,
     value.type,
-    parser.language(),
+    parser,
   );
 
   return {

packages/react-native-codegen/src/parsers/typescript/parser.js

@@ -277,6 +277,13 @@ class TypeScriptParser implements Parser {
       };
     });
   }
+
+  functionTypeAnnotation(propertyValueType: string): boolean {
+    return (
+      propertyValueType === 'TSFunctionType' ||
+      propertyValueType === 'TSMethodSignature'
+    );
+  }
 }
 
 module.exports = {