Skip to content

Commit

Permalink
Fix Suspense throttling mechanism (#26802)
Browse files Browse the repository at this point in the history
Summary:
The throttling mechanism for fallbacks should apply to both their
appearance _and_ disappearance.

This was mostly addressed by #26611. See that PR for additional context.

However, a flaw in the implementation is that we only update the the
timestamp used for throttling when the fallback initially appears. We
don't update it when the real content pops in. If lots of content in
separate Suspense trees loads around the same time, you can still get
jank.

The issue is fixed by updating the throttling timestamp whenever the
visibility of a fallback changes. Not just when it appears.

DiffTrain build for commit facebook/react@4bfcd02.

Reviewed By: hoxyq

Differential Revision: D45920350

Pulled By: sammy-SC

fbshipit-source-id: f5df1709a66e8014d4458fdfdf960d58e0acc45f
  • Loading branch information
acdlite authored and facebook-github-bot committed May 24, 2023
1 parent 7819fef commit 40dbf19
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Renderer/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4cd7065665ea2cf33c306265c8d817904bb401ca
4bfcd02b2cebcb390f5aff0d7747c60a55012d5d

0 comments on commit 40dbf19

Please sign in to comment.