Skip to content

Commit

Permalink
Add DEFINES_MODULE=YES to the yoga podspec (#26276)
Browse files Browse the repository at this point in the history
Summary:
This fixes an error when using RN's version of yoga with Flipper.

```
[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `YogaKit` depends upon `Yoga`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.
```

Taken from https://github.com/facebook/yoga/blob/master/Yoga.podspec#L25

## Changelog

[Internal] [Fixed] - Add `DEFINES_MODULE=YES` to the yoga podspec
Pull Request resolved: #26276

Reviewed By: priteshrnandgaonkar

Differential Revision: D17149819

Pulled By: axe-fb

fbshipit-source-id: 5060b8e7111ba411f6e26e3479ad4fb55a552b4e
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Sep 2, 2019
1 parent 7b9d6d1 commit 0165489
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ReactCommon/yoga/yoga.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ Pod::Spec.new do |spec|

spec.module_name = 'yoga'
spec.requires_arc = false
spec.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES'
}
spec.compiler_flags = [
'-fno-omit-frame-pointer',
'-fexceptions',
Expand Down

0 comments on commit 0165489

Please sign in to comment.