Document how to publish custom React Native version #675

bartolkaruza · 2018-11-11T04:30:59Z

Add documentation page for #653 to the Android Building from Sources doc.

react-native-bot · 2018-11-11T04:38:38Z

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

gengjiawen · 2018-12-02T07:55:54Z

docs/publishing.md

+ This binary needs to become available in your project's `node_modules/react-native/android` folder or directly in your gradle dependency of your Android app. You can achieve this in one of two ways: Git dependency branch, Android binary dependency through Maven.
+
+ To build the .aar React Native library, you can follow the steps to [build from source](building-from-source.md) first to install all required tooling. Then to build the actual library, you can run the following in the root of your react-native checkout:
+ ```$bash


Can you consider make docker part TL, DR. And add links to docker website.

I want to show developers that make a fork is really simple.

gengjiawen · 2018-12-04T12:58:05Z

docs/publishing.md

+Alternatively, if you don't want to 
+install the required toolchain for building from source, you can use a prebuilt docker image to create a react native binary;
+ ```
+ docker run --rm --name rn-build -v $PWD:/pwd -w /pwd gengjiawen/react-native /bin/sh -c "./gradlew installArchives"


Change gengjiawen/react-native to reactnativecommunity/react-native-android

gengjiawen · 2018-12-04T12:58:42Z

docs/publishing.md

+```$bash
+# create .aar, then:
+sed -i '' "s|^/android/||g" .gitignore
+git add android


Maybe just git add android --force.

bartolkaruza · 2018-12-06T08:03:10Z

@gengjiawen I've updated the PR for your comments. Can you clarify what you meant with add links to Docker website? I now added a single link to docker.com, but maybe you meant a specific page.

gengjiawen · 2018-12-07T12:36:28Z

I think this will be good https://docs.docker.com/install/

bartolkaruza · 2018-12-09T05:32:28Z

@gengjiawen could you check the docker command is correct? I don't have it installed on this machine (disk space :P), so I wasn't able to run it yet.

I think otherwise this PR is complete

gengjiawen · 2018-12-09T12:51:15Z

LGTM. Great work.

bartolkaruza · 2018-12-11T15:15:42Z

@grabbou you mentioned you guys maintain a lot of forks at Callstack, would you mind having a quick look at this one?

grabbou · 2018-12-16T22:58:30Z

Will look at it tomorrow, thanks for CCing us.

grabbou · 2019-01-28T10:13:56Z

@facebook-github-bot shipit

Our setup doesn't rely on Docker - I am taking @gengjiawen approval as a green light for this PR. Great job! And sorry for the lag, looks like Christmas break took longer than expected

cpojer

👍

react-native-bot · 2019-02-07T14:13:35Z

Deploy preview for react-native ready!

Built with commit 39470a1

https://deploy-preview-675--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

_{How to Contribute • Documentation Sources}

* [android] document required Network Security Config for React Native packager (#772) * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * add documentation for applying Network Security Config cleartext policy exceptions for RN packager IPs * Update navigation.md (#770) Use createAppContainer instead of createAppNavigator see function declaration here https://github.com/react-navigation/react-navigation/blob/master/src/react-navigation.js#L5 * Update README.md Fixed a few spelling errors in README.md * Deprecating NavigatorIOS (#776) * Deprecating NavigatorIOS * Remove navigator ios * Remove TabBarIOS, TabBarIOS.Item, NavigatorIOS from docs * Make Hello World prettier (#760) Fix #743 * Remove outdated Stetho documentation. * Fix Fresco docs link on the Image Style Props page (#783) * Remove CLI docs (#782) * Update scrollview.md to reflect duration argument (#115) * Update scrollview.md to reflect duration argument facebook/react-native#17422 adds the ability to control the duration of a scrollView animation, for Android only. * sync comments with ScrollView.js * add documentation about `.native.js` extensions (#346) * add documentation about `.native.js` extensions Lots of projects use the `.native.js` to share code between ReactJS and React Native (including core projects, like Jest) but there's no official documentation about it. I'm adding some info so projects can easily discover and refer to this feature. * fix comments and add pro-tip about `.native.js` Fixed the comment on a code block and added a pro-tip telling users to ignore `.native.js` extensions in their web bundlers in order to optimize final bundle size. * Update platform-specific-code.md * Link to all KeyboardType screenshots (#774) * Node version requirement made more prevalent (#775) Reading the first page of https://facebook.github.io/react-native/docs/getting-started.html, it is not clear that the node version needs to be 8+. Just adding this here to help others with installation, specially those of us who already have node running and need to upgrade. * Explicitly state that `activeOpacity` requires `underlayColor` (#781) * Explicitly state that `activeOpacity` requires `underlayColor` It's clear from facebook/react-native#11834 that the underlying issue won't be fixed, so we should update the documentation so people understand that for `activeOpacity` to work, they need to set `underlayColor`. * Update touchablehighlight.md * Add section : Known Issues with fetch and [..] (#769) * Add section : Known Issues with fetch and [..] Cookie based authentication is currently wobbly. Had it not been for the problematic redirect scenario using fetch workarounds could be found (e.g clearing cookies before every single request and manually adding them to the headers). However, because of the 302 issue there is a scenario where using cookies can result in halt of development. The rest of the issues are merely added here so that people that can follow workarounds ( please take a look as unintended consequences might occur ) * Minor text changes and remove the last paragraph. * Document how to publish custom React Native version (#675) * Add section for how to make a git dependency branch (#653) * move publishing a fork to separate page (#653) * updated review comments * link back from building android sources and updated docker link * changed to —force instead of changing .gitignore * Update publishing.md * Update correct signing information for iOS (#766) Ran into this problem while following this guide verbatim. * Update Wix link and title in showcast.json (#763) * change showcast wix logo app * fix file name * Update Wix link and title in showcast * Change wording to improve sentence (#759) * Text/TextInput: Android now supports `maxFontSizeMultiplier` prop (#755) Introduced by this commit: facebook/react-native@4936d28 * Fix typo (#738) * Fix typo * Update linking-libraries-ios.md * update to rn-diff-purge (#761) * Prettify * Sync guides

Add section for how to make a git dependency branch (facebook#653)

366b711

bartolkaruza mentioned this pull request Nov 11, 2018

Add docs for how to easily test & use react native forks #653

Closed

bartolkaruza changed the title ~~Add section for how to make a git dependency branch #653~~ Document how to publish custom React Native version Nov 26, 2018

move publishing a fork to separate page (facebook#653)

e4e58f9

gengjiawen reviewed Dec 2, 2018

View reviewed changes

kelset requested review from hramos and charpeni December 4, 2018 11:57

gengjiawen reviewed Dec 4, 2018

View reviewed changes

updated review comments

9db243e

Bartol Karuza added 2 commits December 9, 2018 10:39

link back from building android sources and updated docker link

45fb138

changed to —force instead of changing .gitignore

e0a2278

gengjiawen approved these changes Dec 9, 2018

View reviewed changes

cpojer approved these changes Feb 7, 2019

View reviewed changes

cpojer added 2 commits February 7, 2019 14:05

Update publishing.md

e5bbc7a

Merge branch 'master' into react-native-fork-doc

39470a1

cpojer merged commit 4b5f00e into facebook:master Feb 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Document how to publish custom React Native version #675

Document how to publish custom React Native version #675

Uh oh!

bartolkaruza commented Nov 11, 2018

Uh oh!

react-native-bot commented Nov 11, 2018 •

edited

Loading

Uh oh!

gengjiawen Dec 2, 2018

Uh oh!

gengjiawen Dec 4, 2018

Uh oh!

gengjiawen Dec 4, 2018

Uh oh!

gengjiawen Dec 4, 2018

Uh oh!

bartolkaruza commented Dec 6, 2018

Uh oh!

gengjiawen commented Dec 7, 2018

Uh oh!

bartolkaruza commented Dec 9, 2018

Uh oh!

gengjiawen commented Dec 9, 2018

Uh oh!

bartolkaruza commented Dec 11, 2018

Uh oh!

grabbou commented Dec 16, 2018

Uh oh!

grabbou commented Jan 28, 2019

Uh oh!

cpojer left a comment

Uh oh!

react-native-bot commented Feb 7, 2019

Uh oh!

Uh oh!

Document how to publish custom React Native version #675

Document how to publish custom React Native version #675

Uh oh!

Conversation

bartolkaruza commented Nov 11, 2018

Uh oh!

react-native-bot commented Nov 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gengjiawen Dec 2, 2018

Choose a reason for hiding this comment

Uh oh!

gengjiawen Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

gengjiawen Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

gengjiawen Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

bartolkaruza commented Dec 6, 2018

Uh oh!

gengjiawen commented Dec 7, 2018

Uh oh!

bartolkaruza commented Dec 9, 2018

Uh oh!

gengjiawen commented Dec 9, 2018

Uh oh!

bartolkaruza commented Dec 11, 2018

Uh oh!

grabbou commented Dec 16, 2018

Uh oh!

grabbou commented Jan 28, 2019

Uh oh!

cpojer left a comment

Choose a reason for hiding this comment

Uh oh!

react-native-bot commented Feb 7, 2019

Uh oh!

Uh oh!

react-native-bot commented Nov 11, 2018 •

edited

Loading