Rename 'unbundle' to 'Random Access Modules bundle' #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlauliac
referenced
this pull request
in facebook/react-native
Jul 30, 2018
Summary: @public Let's get rid of the "unbundle" terminology and instead use "RAM bundle", short for "Random Access Bundle" format. THIS IS A BREAKING CHANGE FOR OSS, as the command becomes `ram-bundle` instead of `unbundle`. It realy shouldn't be a command to start with (only a "format" specifier for the `bundle` command), but I don't want to do that change at this point. Reviewed By: davidaurelio Differential Revision: D8894433 fbshipit-source-id: 5565f9ae94c7c2d7f6b25f95ae45b64f27f6aec8
|
Deploy preview for react-native ready! Built with commit 863b16c https://deploy-preview-477--react-native.netlify.com Changes to Thank you for your contributions. |
|
The docs are versioned. This PR makes the change in the right spot (docs/). The change will only be visible when people switch to "master" in the docs. Once we cut a new version of the framework, we'll do the same for the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We renamed the command in this revision: facebook/react-native@ebf5aea
So we should now change docs to reflect that. Is the doc versioned, though? How do people access docs for older versions of React Native, if at all?
Thanks!