-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] [native-modules-android.md] consistent code for adding package to MainApplication.kt #4047
base: main
Are you sure you want to change the base?
Conversation
Updated the documentation regarding adding packages to MainApplication.kt, so that they are consistent with https://reactnative.dev/docs/native-components-android Further reasoning: The method listed in the pre-commit version did not correctly register modules in my testing, but the version in the proposed change does appear to work as expected
Hi @ChronSyn! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this over @ChronSyn
Updated the documentation regarding adding packages to MainApplication.kt, so that they are consistent with reactnative.dev/docs/native-components-android
We should instead update the other page to follow the same pattern as in the template:
override fun getPackages(): List<ReactPackage> =
PackageList(this).packages.apply {
// Packages that cannot be autolinked yet can be added manually here, for example:
// packages.add(new MyReactNativePackage());
add(MyAppPackage())
}
This looks to match the pre-commit version. That didn't appear to work correctly for me. It seemed that the return type was the cause of the problems, but I wasn't sure why. However, after retesting, I've confirmed that wasn't the issue so I've reintroduced it. I've made an amendment to your suggestion - Further context of why this PR was opened is available at facebook/react-native#41856 . That mentions the same issue, but it doesn't look like a PR was raised for the website docs to be corrected. I've updated both files to be consistent. |
@ChronSyn can you also backport your change to the versioned docs? |
Updated the documentation regarding adding packages to MainApplication.kt, so that they are consistent with https://reactnative.dev/docs/native-components-android
Further reasoning
The method listed in the pre-commit version did not correctly register the module in my testing, but the version in the proposed change does appear to work as expected