Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise documentation for scrollEventThrottle #3971

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Revise documentation for scrollEventThrottle #3971

merged 3 commits into from
Jan 5, 2024

Conversation

NickGerleman
Copy link
Contributor

  1. Recent releases support the prop on Android
  2. As of 0.74, iOS does not throttle by default.

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit cb58f2f
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/659826a6386bad0008bf1dce
😎 Deploy Preview https://deploy-preview-3971--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Simek
Simek approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the updates! 👍

Recent releases support the prop on Android

Was this change included in 0.73 or earlier? If yes, then we need to backport platform tag removal to versioned docs for those releases.

@NickGerleman
Copy link
Contributor Author

Was this change included in 0.73 or earlier? If yes, then we need to backport platform tag removal to versioned docs for those releases.

Sure, let me dig that up.

@NickGerleman
Copy link
Contributor Author

Looks like down to 0.69 facebook/react-native@cf55fd5

@NickGerleman NickGerleman merged commit 0ac8182 into facebook:main Jan 5, 2024
4 checks passed
@NickGerleman NickGerleman mentioned this pull request Jan 8, 2024
Closed
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Jan 8, 2024
@NickGerleman @facebook-github-bot
Update API docs for scrollEventThrottle
b0368b1 
Summary:
We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Jan 8, 2024
@NickGerleman @facebook-github-bot
Update API docs for scrollEventThrottle (facebook#42185)
c921506 
Summary:

We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Jan 11, 2024
@NickGerleman @facebook-github-bot
Update API docs for scrollEventThrottle (facebook#42185)
468b310 
Summary:

We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Jan 11, 2024
@NickGerleman @facebook-github-bot
Update API docs for scrollEventThrottle (facebook#42185)
1c8a7cb 
Summary:

We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 11, 2024
@NickGerleman @facebook-github-bot
Update API docs for scrollEventThrottle (#42185)
3ea0598 
Summary:
Pull Request resolved: #42185

We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092

fbshipit-source-id: 7be1d6e1bc62f38c795b64ad4be5d5c1b23bb742
gokul1099 pushed a commit to gokul1099/react-native-visionos that referenced this pull request Jan 17, 2024
@NickGerleman @gokul1099
Update API docs for scrollEventThrottle (facebook#42185)
c1cb82e 
Summary:
Pull Request resolved: facebook#42185

We've rolled out some changes to the behavior here, mainly that throttling no longer happens by default on iOS.

This updates the documentation, in concert with facebook/react-native-website#3971

Changelog:
[General][Changed] - Update API docs for scrollEventThrottle

Reviewed By: javache

Differential Revision: D52516092

fbshipit-source-id: 7be1d6e1bc62f38c795b64ad4be5d5c1b23bb742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek approved these changes

Assignees
No one assigned
Labels
CLA Signed p: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickGerleman @Simek @facebook-github-bot