-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed peer dependency issues #3942
fixed peer dependency issues #3942
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This reverts commit 1bcb60f.
I missed that these dependencies weren't all already covered, but that CI did not complain that the change would need a lockfile change. I reverted for now, since it looks like it might introduce a new version of major depencies into the three like webpack instead of resolving to the previous one. |
commit 6a28b05 Author: Kartik Shankhavaram <shankhavaramk@gmail.com> Date: Sat Dec 9 22:50:21 2023 +0800 Change 'use' to 'lose' to signify that functions are still accessible (facebook#3949) commit 822b280 Author: Alex Hunt <hello@alexhunt.io> Date: Fri Dec 8 13:00:46 2023 +0000 [docs] Fix name for 0.73 versioned docs (facebook#3948) commit 4818763 Author: Nick Gerleman <ngerlem@meta.com> Date: Thu Dec 7 10:56:32 2023 -0800 Lint and typecheck examples against RN 0.73 (facebook#3946) * Lint and typecheck examples against RN 0.73 Updates the harness for linting snack examples to the newest version of RN. * Update Netlify Node version commit cc46589 Author: Nick Gerleman <ngerlem@meta.com> Date: Thu Dec 7 10:56:04 2023 -0800 Add `alignContent: 'space-evenly'` (facebook#3888) * Add `alignContent: 'space-evenly'` Coming with 0.74 facebook/react-native#41020 * Update layout-props.md commit 9f7093c Author: Christoph Purrer <christophpurrer@gmail.com> Date: Thu Dec 7 14:06:00 2023 +0100 Simplify C++ TM struct generation (facebook#3947) Update documentation to match: facebook/react-native#41645 commit 59278e7 Author: Nick Gerleman <ngerlem@meta.com> Date: Thu Dec 7 01:28:12 2023 -0800 Add `--frozen-lockfile` to `yarn install` (facebook#3945) To catch cases where dependency changes require a lockfile change that wasn't comited alongside. commit 06ba8ea Author: Nick Gerleman <ngerlem@meta.com> Date: Thu Dec 7 00:59:10 2023 -0800 Revert "fixed peer dependency issues (facebook#3942)" (facebook#3944) This reverts commit 1bcb60f. commit 1bcb60f Author: Shantanu Gupta <99300527+Shantanugupta43@users.noreply.github.com> Date: Thu Dec 7 08:52:32 2023 +0000 fixed peer dependency issues (facebook#3942) * fixed peer dependency issues * removed lingering file commit 79ff42a Author: Zeya Peng <zeyap@users.noreply.github.com> Date: Wed Dec 6 14:20:06 2023 -0500 Update native-components-android.md (facebook#3941) commit f0c4b80 Author: Aike van den Brink <17004429+aikewoody@users.noreply.github.com> Date: Wed Dec 6 19:46:03 2023 +0100 Update new-architecture-app-intro.md (facebook#3938) Fixed small spelling mistake commit f89ab82 Author: Alex Hunt <hello@alexhunt.io> Date: Wed Dec 6 17:56:40 2023 +0000 [docs] Cut version 0.73.0 (facebook#3940) commit 83e816b Author: Alex Hunt <hello@alexhunt.io> Date: Wed Dec 6 17:15:14 2023 +0000 [blog] Add 0.73 announcement post (facebook#3931) commit d8c78ad Author: Thibault Malbranche <thibault.malbranche@epitech.eu> Date: Wed Dec 6 17:33:48 2023 +0100 fix(Image): update link to correct file (facebook#3939) commit 821172e Author: Sarvar Rose <47109217+sarvarrose@users.noreply.github.com> Date: Mon Dec 4 16:20:11 2023 +0530 correct type of Pressable `style` prop (facebook#3936) commit b1379a7 Author: adriancuadrado <adriancuadradochavarria97@gmail.com> Date: Mon Dec 4 00:57:19 2023 +0100 Update scrollview.md (facebook#3869) `pagingEnabled` **is** supported on Android. I tested it and it just seems to work. commit 11258b1 Author: Alan <49978973+3Alan@users.noreply.github.com> Date: Mon Dec 4 07:55:12 2023 +0800 fix: remove useless points (facebook#3934) commit 8400279 Author: Christoph Purrer <christophpurrer@gmail.com> Date: Sun Dec 3 09:57:25 2023 +0100 Revert "Simplify C++ TM struct generation (facebook#3930)" (facebook#3935) This reverts commit 7396470. commit 7396470 Author: Christoph Purrer <christophpurrer@gmail.com> Date: Mon Nov 27 13:00:23 2023 +0100 Simplify C++ TM struct generation (facebook#3930) Update documentation to match: facebook/react-native#41645 commit 5616873 Author: Bailey Lissington <54869395+llamington@users.noreply.github.com> Date: Mon Nov 27 22:33:50 2023 +1300 Fixed grammatical error (facebook#3929)
Fixed peer dependency issues
Before fix
After fix