Skip to content

Conversation

@tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented May 31, 2023

enterKeyHint supports following values but docs are missing one value go.
Also, enter is equivalent to UIReturnKeyType default and supported in iOS only.

export type enterKeyHintType =
  // Cross Platform
  | 'done'
  | 'go'
  | 'next'
  | 'search'
  | 'send'
  // Android-only
  | 'previous'
  // iOS-only
  | 'enter';
image

Tests

https://deploy-preview-3739--react-native.netlify.app/docs/textinput#enterkeyhint

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 6dbc615
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/689602acc652fd000856385f
😎 Deploy Preview https://deploy-preview-3739--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tarunrajput tarunrajput force-pushed the add-missing-go-value-in-enterKeyHint branch from 87e4e76 to 539f1e8 Compare May 31, 2023 07:16
@Simek Simek added 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels May 31, 2023
@tarunrajput
Copy link
Contributor Author

@Simek, could we merge this?

@cortinico
Copy link
Contributor

@Simek, could we merge this?

I believe yes, not sure why @Simek you added "Waiting on future release"

@Simek
Copy link
Collaborator

Simek commented Dec 9, 2023

I believe that I have added labels since at te moment of PR publish, changes has not been merged to core repo yet, and thus was not sure when they land and which version the changes be a part of. Usually we update those labels in docs after the PRs land, or when preparing docs cut for new version.

@tarunrajput Can you backport the changes to versioned 0.73 docs before we ship this out, since this change has landed as a part of this release?

@Simek Simek removed 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged Wait on future Release This indicates a PR that updates the doc to match a future release. labels Dec 9, 2023
@tarunrajput tarunrajput force-pushed the add-missing-go-value-in-enterKeyHint branch from 539f1e8 to 049120c Compare December 9, 2023 15:46
@Simek Simek merged commit 6abd743 into facebook:main Aug 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants