add styles for non-linkable sidebar entries #2883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 861665d 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61bb574558db780008379919 😎 Browse the preview: https://deploy-preview-2883--react-native.netlify.app |
Simek
added a commit
to Simek/react-native-website
that referenced
this pull request
Dec 21, 2021
lunaleaps
approved these changes
Dec 24, 2021
|
+1 to the indentation and style updates! I'll leave it to you when you want to merge! Thanks @Simek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2882
So far we were not using non-linkable grouping in the sidebar (
collapsible: false), but this feature could be leverage for the The New Architecture guide and future website content. This also enables us to rethink the current sidebar organization, which also can benefit for those non-linkable sections.At this moment titles of the groups looks like the regular entry, which might confuse the users, This PR adds the proper styling for those sidebar headers and also fixes the missing indentation and unintended font size overwrite at the sidebar top-level after one of the latest Docusaurs updates.
Preview