Fix FlexShrink default value #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On react-native flexShrink default value is not 1 but 0. 1 is the default value for the web and this can be confusing.
|
Deploy preview for react-native ready! Built with commit ce522f4 |
|
@Titozzz Hmm, according to the Yoga Layout docs, the default value is Also I was not able to find the code altering this value in Yoga (https://github.com/facebook/yoga/search?p=1&q=flexshrink), nor React Native (https://github.com/facebook/react-native/search?p=1&q=flexshrink) source. Can you provide the link to the source or place where this discrepancy can bee seen? |
|
you can see that even react native web uses this default: https://snack.expo.io/EsBsku4O0 |
|
But I do agree that all the docs say it's 1 which is why it's confusing |
Simek
approved these changes
Feb 1, 2021
This was referenced Feb 2, 2021
1 task
|
This is not complete... Forgot to update https://reactnative.dev/docs/layout-props#flexshrink |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On react-native flexShrink default value is not 1 but 0. 1 is the default value for the web and this can be confusing.