Report WebSocket connection termination error code and message #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzaidman
force-pushed
the
websocket-connection-lost-error-reporting
branch
2 times, most recently
from
a3808f9 to
8918992
Compare
hoxyq
reviewed
Mar 25, 2025
| static show(reason: string): void { | ||
| static show( | ||
| uiMessage: string, | ||
| connectionLostDetails: {reason: string, code: string, errorType: string} = {reason: '', code: '', errorType: ''} |
There was a problem hiding this comment.
Does it have to be initialized with empty strings? I thought reason is always present, even if it is just empty string. Other fields may be optional, but do we actually need to set them to empty strings? I think you can have optional fields in event payloads in RNPerfMetrics
There was a problem hiding this comment.
Thanks!
You are right. I've made all these fields optional here and in the corresponding diff D71821154.
vzaidman
force-pushed
the
websocket-connection-lost-error-reporting
branch
from
8918992 to
11843fb
Compare
hoxyq
approved these changes
Mar 25, 2025
This was referenced Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When WebSocket disconnects, we are reporting an event, but we were not reporting the disconnection code / error type that could tell us why disconnections occur on Frontend.
Test
Tested reporting the event e2e: D71742575