This repository was archived by the owner on Jun 26, 2020. It is now read-only.
[WIP] Fixes for ReactNative on Fiber #528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if that one gets merged but it fixes other issues so it's likely.
Also switch it to use the same `updater` code path both in Stack and Fiber. This removes knowledge about internal data structure from the frontend.
gaearon
force-pushed
the
fiber-devtools-fixes
branch
from
5fdb287 to
f860840
Compare
* We shouldn't rely on the assumption that we're operating on current Fiber * The idea to unify updaters with setInProps() was a bad one because setNativeProps() signature is too different
gaearon
force-pushed
the
fiber-devtools-fixes
branch
from
f860840 to
2e0086f
Compare
gaearon
commented
Feb 18, 2017
| @@ -112,6 +112,15 @@ function getData(element: Object): DataType { | |||
| } | |||
| } | |||
|
|
|||
| if (typeof element.setNativeProps === 'function') { | |||
There was a problem hiding this comment.
Note to self: this depends on how we expose host instances in the end.
It might be that we'll just expose this from RN renderer instead, and it will have to inject setNativeProps(tag) just like it does with resolveStyle().
|
Closing in favor of a new branch, pushed to facebook/react-devtools so Dom and I can both work on it, with conflicts from master resolved. 😄 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP