Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 3, 2019

This basically reverts #1258. It is being done to fix interaction names within the Profiler.

Resolves #1262

This is being done to fix interaction names within the Profiler.
@gaearon
Copy link
Contributor

gaearon commented Jan 3, 2019

Can we fix just the profiler stuff alone somehow?

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 3, 2019

Can we fix just the profiler stuff alone somehow?

Requests sent through the Bridge are batched and treated pretty generically.

Maybe the profiler could proactively "hydrate" interactions during the commit phase (the only time when we know the data will actually still be around to hydrate) so that we serialize a little more information about them? This would slow down the commit phase though.

I can give it a little more thought before merging this I guess.

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 3, 2019

After thinking about this a little more, I don't think there's a great alternative (that would not involve making more significant changes to the bridge architecture).

I considered trying to explicitly hydrate the root fiber's memoizedInteractions set during the commit phase (when profiling), but I think this wouldn't work– since the ProfilerStore assumes things can be committed synchronously but bridge hydration is asynchronous.

I also briefly considered trying to special case the serialization threshold for root fibers and/or the interactions Set somehow but I'm not sure how that could be cleanly accomplished with the current layers of abstraction.

@bvaughn bvaughn merged commit d6ddb75 into facebook:master Jan 3, 2019
@bvaughn bvaughn deleted the increase-bridge-serialization-threshold branch January 3, 2019 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interaction labels are broken in master

3 participants