This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Disable props/state inspection for Profiler #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jan 2, 2019
|
|
||
| inspect() { | ||
| if (this.props.inspect === null) { | ||
| return; |
Contributor
There was a problem hiding this comment.
Might be worth commenting why this is useful. Someone later might look at this code and think: "I'll just simplify this by passing an empty function!"
gaearon
approved these changes
Jan 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for something I noticed while testing #1258
Inspecting props/state within the Profiler never worked right because React mutates fibers, so older "snapshots" of props/state can't be inspected. However the UI seemed to suggest that props could be expanded– which was confusing.
This changes things to make the UI more intuitive. For example, the
state.objectobject below doesn't show a carrot or mouse pointer cursor for inspecting.Here's the Elements panel style:
And here's the Profiler panel style:
I also changed the
DataViewcomponent displayed inside of the profiler to expand objects by default up until the point where they're dehydrated, to offset the fact that we don't allow you to toggle them expanded/collapsed any more.