Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Visually identify canary builds #1239

Closed
wants to merge 5 commits into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Nov 26, 2018

Added a new icon (below) and popup text for canary builds.

New icon

I don't think this is necessary but it could be useful. Dev builds will continue to show the same icon as before, but production builds will show the canary icon (if they're canaries) to make sure people are aware of deploying a canary in production.

Firefox

screen shot 2018-11-26 at 11 31 01 am

Chrome

screen shot 2018-11-26 at 11 31 34 am

New popup content

In addition to this, the popup text will link to the commit that the canary was created from.

Production canary

screen shot 2018-11-26 at 3 23 43 pm

Development canary

screen shot 2018-11-26 at 3 23 49 pm

@@ -0,0 +1,69 @@
<svg id="Outdated" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1024 1024">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using https://jakearchibald.github.io/svgomg/ to optimize the svg.

<svg id="Outdated" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1024 1024"><defs><style>.cls-1{fill:#ffba00}.cls-2{fill:#fff}</style></defs><rect class="cls-1" width="1024" height="1024" rx="96" ry="96" id="Background"/><g id="Rings"><path class="cls-2" d="M510 325c-249 0-450 83-450 185s201 185 450 185 450-83 450-185-201-185-450-185zm0 330c-225 0-407-65-407-145s182-145 407-145 408 65 408 145-183 145-408 145z"/><path class="cls-2" d="M670 417C546 202 373 69 285 120s-59 267 65 482 297 349 385 298 59-267-65-483zM384 583c-112-195-147-386-78-426s217 86 329 280 148 385 78 425-216-85-329-279z"/><g id="BLOCKER"><path class="cls-1" transform="rotate(39 725.584 779.096)" d="M564 572h315v397.12H564z"/><path class="cls-1" transform="rotate(21 834.313 556.928)" d="M685 379h283v360.81H685z"/></g><path class="cls-2" d="M670 603c124-215 153-431 65-482s-261 81-385 296-153 432-65 483 261-82 385-297zM384 437c113-194 260-320 330-280s34 231-78 425-260 321-330 281-34-231 78-426z"/></g><circle class="cls-2" cx="512" cy="512" r="80" id="Circle"/><path transform="translate(585 585)" d="M372.888 3.417C370.942 1.471 367.649.678 361.52.678c-27.119 0-107.25 15.936-169.59 52.773l-2.123 1.254-9.154 75.342-21.625-54.922-5.274 4.101c-8.973 6.976-17.139 14.13-24.271 21.262-34.747 34.747-58.945 73.784-68.136 109.918-7.562 29.727-4.785 56.001 7.688 75.652L4.393 350.699c-5.858 5.858-5.858 15.355 0 21.213 2.929 2.929 6.768 4.394 10.606 4.394s7.678-1.464 10.606-4.394l64.652-64.652c12.327 7.798 27.362 11.868 44.258 11.869h.003c43.844 0 95.348-26.356 141.297-72.306.854-.854 1.701-1.728 2.589-2.646l5.212-5.384-60.929-23.991 87.707-10.657 1.275-1.917c12.748-19.177 24.504-40.653 34.943-63.832l2.154-4.784-44.544-17.539 54.349-6.604 1.057-2.866c7.921-21.486 13.639-44.894 16.101-65.91 1.65-14.06 2.494-31.941-2.841-37.276z" fill="#202020" id="Feather"/></svg>

1.16k → 1014 bytes 85.07%

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2019

React DevTools has been rewritten and recently launched a new version 4 UI 🎉 The source code for this rewrite was done in a separate repository and is being merged into the main React repo.

Thank you for taking the time to contribute to this extension 🙇‍♂️

Because this PR is for the version code base, I am closing it. If you'd like to contribute to the new extension, please visit the new repository.

@bvaughn bvaughn closed this Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants