This repository was archived by the owner on Jun 26, 2020. It is now read-only.
improve scrolling to element #1072
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this tweet and thought I'd give it a go: https://twitter.com/aweary/status/1025789362607255552
Related issue: #746
This PR adds support for horizontal scrolling and also ensures that vertical scrolling is always in view. There's room for improvements though:
scroll-margin
CSS inscroll-into-view-if-needed
soon which will allow changing that.Benefits to using the
scroll-into-view-if-needed
ponyfill, and later possiblyscroll-margin
:Thoughts? 😃