-
Notifications
You must be signed in to change notification settings - Fork 98
Handling @overload with a docstring declaration #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks! The For this type of feature, could you please add an integration test here? https://github.com/facebook/pyrefly/blob/main/pyrefly/lib/test/overload.rs Also, I think we should only allow docstrings for function bodies if there is an For example, a program like this should still be invalid:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to you with comments, lmk if you have any questions. Thanks!
Should be fixed. Added 3 test cases, first one is the basic one. Second one was to make sure that stuff after a docstring would still be typechecked properly and if the body of the function had more info, it wouldn't deem it a stub. The last one is for the case you mentioned of the nonoverloaded function with a docstring. |
My commits are a bit messy because I am a little new to this but the code should be right |
Also if you have others that you want me to fix, let me know! I am a bit swamped right now but I can try and get to it soon. |
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
fixes #359. Added a check to make sure the body was not a docstring. Also added a test in the the third_party folder to show that the change is working. Let me know if anything needs to be changed.